Type-erase the read_options parameter of SecondaryIndex::NewIterator #13334
+71
−78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The patch type-erases the `read_options` parameter of `SecondaryIndex::NewIterator` using `std::any` and renames the earlier `SecondaryIndexReadOptions` (which only contained options related to similarity search) to `FaissIVFIndexReadOptions`. This enables custom `SecondaryIndex` implementations to have their own read option structures and avoids the need to pass options which are irrelevant to them. At the same time, type erasure preserves the ability to call `NewIterator` polymorphically, which in turn enables us to hide the `FaissIVFIndex` class from the public API. Differential Revision: D68694317
|
This pull request was exported from Phabricator. Differential Revision: D68694317 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The patch type-erases the
read_optionsparameter ofSecondaryIndex::NewIteratorusingstd::anyand renames the earlierSecondaryIndexReadOptions(which only contained options related to similarity search) toFaissIVFIndexReadOptions. This enables customSecondaryIndeximplementations to have their own read option structures and avoids the need to pass options which are irrelevant to them. At the same time, type erasure preserves the ability to callNewIteratorpolymorphically, which in turn enables us to hide theFaissIVFIndexclass from the public API.Differential Revision: D68694317