Add data-disabled to test fixtures
#1286
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D45723003 |
|
cc @nicoburns |
Summary: Pull Request resolved: facebook#1286 This can be marked in fixtures to skip a test without commenting it out. We add one more usage of this. The same functionality existed (unused) before for `experiments`, which I changed to `data-experiments`. Formatting of JS tests changed to be closer to what Prettier would output, and to remove usage of `Yoga.UNDEFINED` which doesn't existi and just resolves to `undefined` (this is converted to NaN by the wrapper layer). Reviewed By: yungsters Differential Revision: D45723003 fbshipit-source-id: fedd16a248b8fe2541ab500731b58f4b01129339
NickGerleman
force-pushed
the
export-D45723003
branch
from
00bba38 to
eddb13e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45723003 |
|
This pull request has been merged in e769dd9. |
|
@NickGerleman This is awesome. Does this mean that #1194 is now unblocked? I have some work in progress to export Taffy's test fixtures to Yoga. I'll try to get that into a publishable state, but it might make sense to merge #1194 first, as Taffy has already imported versions of those fixtures and they would therefore be included in an export. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This can be marked in fixtures to skip a test without commenting it out. We add one more usage of this.
The same functionality existed (unused) before for
experiments, which I changed todata-experiments.Formatting of JS tests changed to be closer to what Prettier would output, and to remove usage of
Yoga.UNDEFINEDwhich doesn't existi and just resolves toundefined(this is converted to NaN by the wrapper layer).Differential Revision: D45723003