Accept only non-batched tensor in TextTokenDecoder #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the inconsistency between
TextTokenEncoderandTextTokenDecoder, where the former accepts only a single string, while the latter accepts only a batched tensor.TextTokenDecodernow accepts only a one-dimensional tensor holding the token indices of a single sentence and returns a string instead of a list of strings (another issue with batching in the decoder was the lack of pad handling). Batching is typically handled by the code that performs decoding (e.g.SequenceToTextGenerator). Also included is a nit convenienceCStringmethodstrip, which internally callsltrimandrtrim.