fix(libscap,libsinsp): correctly manage memfd in scapfiles #1324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poiana
added
release-note-none
kind/bug
therealbobo
changed the title
|
Great catch! |
therealbobo
force-pushed
the
fix/scap-fd-memfd
branch
from
12f2c43 to
81dc03e
Compare
therealbobo
changed the title
FedeDP
reviewed
Sep 5, 2023
|
Asan spotted an issue! |
Signed-off-by: Roberto Scolaro <[email protected]>
Signed-off-by: Roberto Scolaro <[email protected]>
therealbobo
force-pushed
the
fix/scap-fd-memfd
branch
from
81dc03e to
88a2fd2
Compare
FedeDP
reviewed
Sep 5, 2023
therealbobo
force-pushed
the
fix/scap-fd-memfd
branch
from
88a2fd2 to
cd9a57b
Compare
|
LGTM label has been added. Git tree hash: f726290ee2eb911e854f8ea7494dca8f271339e0
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, therealbobo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Merged
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area libscap
/area libsinsp
Does this PR require a change in the driver versions?
What this PR does / why we need it:
New
scap_fd_typewere introduced but their parsing logic was not added toscap_savefile.c, breaking captures. Moreover the correspondents were missing in libsinsp.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: