chore: improve libcurl dependency reference

[federico-sysdig]

What type of PR is this?
/kind cleanup

Any specific area of the project related to this PR?
/area build

Does this PR require a change in the driver versions?
no

What this PR does / why we need it:
Library libcurl can be referenced in a more structured way by using CMake's find_package mechanism. This allows falcosecurity-lib to build also in other scenarios, e.g. with Vcpkg as a package manager.

Which issue(s) this PR fixes:
none

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

[poiana]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: federico-sysdig
Once this PR has been reviewed and has the lgtm label, please assign incertum for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[github-actions]

Perf diff from master - unit tests

     3.61%     +0.60%  [.] gzfile_read
    10.70%     -0.58%  [.] sinsp_parser::reset
     1.38%     +0.47%  [.] sinsp::fetch_next_event
     1.91%     -0.38%  [.] scap_event_decode_params
    11.80%     -0.30%  [.] sinsp::next
     1.08%     -0.21%  [.] sinsp_parser::parse_context_switch
     0.22%     +0.21%  [.] sinsp_threadinfo::get_fd
     2.66%     +0.20%  [.] sinsp_thread_manager::get_thread_ref
     0.31%     +0.19%  [.] std::_Hashtable<unsigned long, std::pair<unsigned long const, std::shared_ptr<ppm_evt_hdr> >, std::allocator<std::pair<unsigned long const, std::shared_ptr<ppm_evt_hdr> > >, std::__detail::_Select1st, std::equal_to<unsigned long>, std::hash<unsigned long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::find
     1.15%     -0.19%  [.] std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            +0.0183         +0.0183           147           149           147           149
BM_sinsp_split_median                                          +0.0187         +0.0187           146           149           146           149
BM_sinsp_split_stddev                                          +0.1694         +0.1695             1             2             1             2
BM_sinsp_split_cv                                              +0.1484         +0.1486             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  -0.1158         -0.1158            61            54            61            54
BM_sinsp_concatenate_paths_relative_path_median                -0.1423         -0.1423            61            53            61            53
BM_sinsp_concatenate_paths_relative_path_stddev               +14.2845        +14.2744             0             2             0             2
BM_sinsp_concatenate_paths_relative_path_cv                   +16.2854        +16.2742             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     +0.0288         +0.0287            24            25            24            25
BM_sinsp_concatenate_paths_empty_path_median                   +0.0299         +0.0299            24            25            24            25
BM_sinsp_concatenate_paths_empty_path_stddev                   -0.4737         -0.4740             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       -0.4884         -0.4887             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  -0.1662         -0.1663            66            55            66            55
BM_sinsp_concatenate_paths_absolute_path_median                -0.1749         -0.1749            67            55            67            55
BM_sinsp_concatenate_paths_absolute_path_stddev                -0.7943         -0.7947             1             0             1             0
BM_sinsp_concatenate_paths_absolute_path_cv                    -0.7533         -0.7538             0             0             0             0
BM_sinsp_split_container_image_mean                            +0.0168         +0.0168           386           393           386           393
BM_sinsp_split_container_image_median                          +0.0153         +0.0153           387           393           387           393
BM_sinsp_split_container_image_stddev                          +0.3510         +0.3505             2             2             2             2
BM_sinsp_split_container_image_cv                              +0.3286         +0.3282             0             0             0             0

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.44%. Comparing base (d1881b4) to head (8792181).
Report is 3 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2145   +/-   ##
=======================================
  Coverage   75.44%   75.44%           
=======================================
  Files         265      265           
  Lines       34057    34057           
  Branches     5801     5801           
=======================================
+ Hits        25694    25695    +1     
+ Misses       8363     8362    -1     

Flag	Coverage Δ
libsinsp	75.44% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[FedeDP]

Can you rebase on latest master? Thanks, should help with the CI :)

[federico-sysdig]

Can you rebase on latest master? Thanks, should help with the CI :)

@FedeDP I've rebased a second time. I noticed a batch of several commits has been merged.

[FedeDP]

/milestone 0.20.0

[FedeDP]

There are still a bunch of failures here; care to rebase and eventually fix them?

[FedeDP]

So, static builds and zig builds are broken :/

There is no hurry for this one, for now i'll move it to next milestone; if we are able to fix it sooner, we can move it back to 0.20.

/milestone 0.21.0

[FedeDP]

/reopen
Sorry, wrong click!

[poiana]

@FedeDP: Reopened this PR.

In response to this:

/reopen
Sorry, wrong click!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.