Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(ci): add check for clang-format styling #29

Merged
merged 3 commits into from
Nov 17, 2023

Conversation

jasondellaluce
Copy link
Contributor

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

/area plugin-sdk

What this PR does / why we need it:

Which issue(s) this PR fixes:

Makes sure we check for code style every PR, since we did it so far.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@jasondellaluce jasondellaluce force-pushed the new/clang-format-ci-check branch from 1889f3a to 763d925 Compare November 17, 2023 12:08
@poiana poiana added size/M and removed size/S labels Nov 17, 2023
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link

poiana commented Nov 17, 2023

LGTM label has been added.

Git tree hash: aefbe5ad4164c61a066dbdf912e62f8eb18a2e12

@poiana
Copy link

poiana commented Nov 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, jasondellaluce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@FedeDP
Copy link
Contributor

FedeDP commented Nov 17, 2023

Nice!

@poiana poiana merged commit 2097bdb into master Nov 17, 2023
2 checks passed
@poiana poiana deleted the new/clang-format-ci-check branch November 17, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants