update gradle build tools and gradle version used #1000
Conversation
| @@ -72,7 +72,6 @@ android { | |||
| * Update (both Gradle and local SDK) whenever possible | |||
| */ | |||
| compileSdkVersion 27 | |||
| buildToolsVersion '27.0.3' | |||
There was a problem hiding this comment.
This shouldn't be set to buildToolsVersion "28.0.3"?
| @@ -2,7 +2,6 @@ apply plugin: 'com.android.library' | |||
|
|
|||
| android { | |||
| compileSdkVersion 27 | |||
| buildToolsVersion "27.0.3" | |||
There was a problem hiding this comment.
This shouldn't be set to buildToolsVersion "28.0.3"?
There was a problem hiding this comment.
Nope, as mentioned in the PR description the new gradle build tools have their own internal default for android.buildToolsVersion. For gradle build tools 3.2.1 that default is 28.0.*. Not specifying this is fine and reduces the overhead to keeping an app up to date - keep gradle build tools up to date and you'll be up to date with android build tools too
|
|
||
| <uses-sdk android:minSdkVersion="8" android:targetSdkVersion="21" /> | ||
| </manifest> | ||
| android:versionName="3.3.0" /> |
There was a problem hiding this comment.
This change is a bit unrelated to the topic of this PR but it's OK.
Next time I'd put it, at least, in a separate commit.
There was a problem hiding this comment.
It's not, as mentioned in the PR description build tools 3.2.1 added a bunch of warnings and errors. One was an error when SDK versions are specified in the manifest. If I remember right it actually only errors on targetSdkVersion and minSdkVersion was a warning but I figured removing one would be a less clear change
There was a problem hiding this comment.
I split it out anyone into #1006, if that gets merged first I'll rebase this branch 👍
3.2.1requires gradle 4.6 or above and adds a bunch of build errors and warnings.It has a default
buildToolsVersionnow so specifying one is no longer necessary. it also errors on sdk versions being specified in the manifest