-
Notifications
You must be signed in to change notification settings - Fork 136
[Suggestion] Pokedex number view in scan result #865
base: master
Are you sure you want to change the base?
Conversation
Hi @nahojjjen, Thanks for your comment in my issue.
Examples of use-cases when knowing pokedex number would be useful.
These operations become more complicated according to the count of collected pokemons. If GoIV could display this number, users are able to know and remember it more easily In these use-cases, using pokemon name also causes the same result. |
I think you've implemented this well, and I think I can understand your usecases, however I dont think the information should be presented in the quick-iv button. The quick iv button is only for the most essential information. By the way, unless I misunderstand, all your usecases are for searching / filtering pokemon, why not write the pokemon name instead? As a sidenote, you can currently check the pokedex number of a pokemon in GoIV by pressing the iv button, and then pressing the pokemon species name. |
@nahojjjen thanks for your comment and sharing your thinkings.
OK, I had not recognized this important UI policy. I feel this quick-iv preview very useful because information appears without user operations. In that case I could remove this view from the quick-iv button and remake my PR.
Because filtering with pokedex numbers would be faster than with names
Yes I know. So I wish I could check this number more quickly and simply because of some use-cases I listed in my previous comment. What do you think about the plan to add pokedex number view to only result dialog like following? |
The UI code is currently being rewritten in preparation for GoIV 5.0.0, so we cant merge a change in that class right now, however the suggestion you sent with the dex# in the resultview in front of the pokemon name looks pretty good. I think it'd be best if we revisited that idea once the 5.0.0 UI code has been merged. |
@nahojjjen Thanks for your positive comment. 😃 I have two questions.
|
The (poorly named) branch movesetEvalk was merged to master yesterday |
This PR can stay up as a reminder for the time being |
@nahojjjen OK. Thanks for your answer. |
Hi GoIV pj team.
I have a small suggestion for GoIV.
I think it is useful that the pokedex number is displayed in a scan result.
In Pokemon Go game app, as you know,
we can use pokedex numbers for filtering pokemons, like following:
If GoIV displays the pokedex number simply and quickly in a scan result,
we can select specific pokemon by this number without going back from Pokedex menu
or switching app and visiting other pokedex info web site.
That's useful, I think.
So with this PR, I suggest the way to display the pokedex number in a scan result.
In my implementation, pokedex number is placed before the pokemon name.
What do you think about this suggestion?
Would you tell me your good idea?
Screen images are following: