Skip to content
This repository has been archived by the owner on Jan 23, 2024. It is now read-only.

[Suggestion] Pokedex number view in scan result #865

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

udnp
Copy link
Contributor

@udnp udnp commented Feb 6, 2018

Hi GoIV pj team.

I have a small suggestion for GoIV.
I think it is useful that the pokedex number is displayed in a scan result.

In Pokemon Go game app, as you know,
we can use pokedex numbers for filtering pokemons, like following:
device-2018-02-06-002643

If GoIV displays the pokedex number simply and quickly in a scan result,
we can select specific pokemon by this number without going back from Pokedex menu
or switching app and visiting other pokedex info web site.
That's useful, I think.

So with this PR, I suggest the way to display the pokedex number in a scan result.
In my implementation, pokedex number is placed before the pokemon name.

What do you think about this suggestion?
Would you tell me your good idea?

Screen images are following:

@udnp
Copy link
Contributor Author

udnp commented Feb 6, 2018

quick IV preview with pokedex nubmer(Left: Without Pokedex# / Right: With Pokedex#)
vs-pokedex-number-view

@udnp
Copy link
Contributor Author

udnp commented Feb 6, 2018

scan result dialog with pokedex nubmer(Left: Without Pokedex# / Right: With Pokedex#)
vs-pokedex-number-view-in-scan-result

@udnp
Copy link
Contributor Author

udnp commented Feb 8, 2018

Hi @nahojjjen, Thanks for your comment in my issue.

udnp#15 (comment)

Hey, I'm not sure I understand when knowing this number would be useful, could you clarify the use-case a bit?

Examples of use-cases when knowing pokedex number would be useful.
Do these answer your comment?

  • selecting specific pokemons as battle members on the starting battle
  • restore specific pokemons by using potions/revives
  • comparing caught pokemon immediately with the same species caught previously(like following movie)
    device-2018-02-09-043018

These operations become more complicated according to the count of collected pokemons.
So filtering by pokedex number is useful,
but it is hard to memorize a lot of pokedex numbers.

If GoIV could display this number, users are able to know and remember it more easily
than searching in deep Pokedex Menu of Pokemon Go game app.

In these use-cases, using pokemon name also causes the same result.
But I feel using pokedex number can do more quickly and simply.

@nahojjjen
Copy link
Collaborator

I think you've implemented this well, and I think I can understand your usecases, however I dont think the information should be presented in the quick-iv button. The quick iv button is only for the most essential information.

By the way, unless I misunderstand, all your usecases are for searching / filtering pokemon, why not write the pokemon name instead?

As a sidenote, you can currently check the pokedex number of a pokemon in GoIV by pressing the iv button, and then pressing the pokemon species name.

@udnp
Copy link
Contributor Author

udnp commented Feb 11, 2018

@nahojjjen thanks for your comment and sharing your thinkings.

however I dont think the information should be presented in the quick-iv button. The quick iv button is only for the most essential information.

OK, I had not recognized this important UI policy.

I feel this quick-iv preview very useful because information appears without user operations.
So in order to know pokedex number by as few user operations as possible,
I experimented with the quick-iv button.

In that case I could remove this view from the quick-iv button and remake my PR.

By the way, unless I misunderstand, all your usecases are for searching / filtering pokemon, why not write the pokemon name instead?

Because filtering with pokedex numbers would be faster than with names
(especially on non alphabetic language Japanese IME 😢).
Everyday I play many pokemon gym battles,
and I feel this is the best way to assign my ハピナス(Blissey) to the gym faster than anyone,
as soon as possible after a battle. 😄

As a sidenote, you can currently check the pokedex number of a pokemon in GoIV by pressing the iv button, and then pressing the pokemon species name.

Yes I know.
In my GoIV configuration, [Enable scan correction dialog] is turned off
and [Expanded appraisal opened by default] is turned on.
Therefore in my understanding, to check this number by your way,
I need one more operation, tapping the [BACK] button before tapping the pokemon species name.

So I wish I could check this number more quickly and simply because of some use-cases I listed in my previous comment.

What do you think about the plan to add pokedex number view to only result dialog like following?
If you have any other thinkings or questions, feel free to ask.

device-2018-02-06-003424

@nahojjjen
Copy link
Collaborator

The UI code is currently being rewritten in preparation for GoIV 5.0.0, so we cant merge a change in that class right now, however the suggestion you sent with the dex# in the resultview in front of the pokemon name looks pretty good. I think it'd be best if we revisited that idea once the 5.0.0 UI code has been merged.

@udnp
Copy link
Contributor Author

udnp commented Feb 15, 2018

@nahojjjen Thanks for your positive comment. 😃
Until then I'll use my private GoIV build for checking pokedex number.

I have two questions.

  1. Could I check new UI codes progressing toward version 5.0.0?
    Is the branch "movesetEvakl"?

  2. Could this PR [Suggestion] Pokedex number view in scan result #865 be stay open until the 5.0.0 UI code merged?
    Or should this be closed once and new other #number PR/issue needed?

@nahojjjen
Copy link
Collaborator

The (poorly named) branch movesetEvalk was merged to master yesterday

@nahojjjen
Copy link
Collaborator

This PR can stay up as a reminder for the time being

@udnp
Copy link
Contributor Author

udnp commented Feb 15, 2018

@nahojjjen OK. Thanks for your answer.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants