Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncate comment in vcs_PullRequestComment records to 1000 chars #1147

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

tovbinm
Copy link
Contributor

@tovbinm tovbinm commented Sep 13, 2023

Description

Avoid writing very long comment messages into the graph.

Type of change

  • Bug fix
  • New feature
  • Breaking change

Related issues

The actual error:

index row requires 9352 bytes maximum size is 8191

reported in faros-ai/faros-community-edition#312

@tovbinm tovbinm changed the title Truncate vcs_PullRequestComment comments to 1000 chars Truncate comment in vcs_PullRequestComment records to 1000 chars Sep 13, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@@ -2,7 +2,7 @@ import {AirbyteRecord} from 'faros-airbyte-cdk';
import {Utils} from 'faros-js-client';

import {DestinationModel, DestinationRecord} from '../converter';
import {AzureReposConverter} from './common';
import {AzureReposConverter, MAX_DESCRIPTION_LENGTH} from './common';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAX_COMMENT_LENGTH?

@tovbinm tovbinm merged commit 88a0395 into main Sep 14, 2023
@tovbinm tovbinm deleted the mt/truncate-comments branch September 14, 2023 00:50
@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants