Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fresh): wait for initial storage read before returning token #96

Merged
merged 4 commits into from
Jul 20, 2024

Conversation

lulupointu
Copy link
Contributor

This fix allows the initial token to be fetched asynchronously. See #70 for a snippet describing the issue

…icated) before returning the token

This fix allows initial token to be fetched asynchronously. See felangel#70 for a snippet describing the issue
@lulupointu lulupointu requested a review from felangel as a code owner February 14, 2024 16:55
@lulupointu lulupointu closed this Feb 14, 2024
@lulupointu lulupointu reopened this Feb 29, 2024
taboulot added a commit to bamlab/fresh that referenced this pull request Apr 3, 2024
@kuhnroyal
Copy link

@felangel can you take a look at this by any chance? I know it's not a macro but it also needs some love 😁

@vasilich6107
Copy link

@felangel this bug definitely bug
@lulupointu thanks a lot for this PR

@vasilich6107
Copy link

Hi @felangel
Could you take a look at this issue?

@vasilich6107
Copy link

@felangel
Could you take a look at this PR?

@felangel felangel changed the title Fix: Wait for the status to be determined (authenticated or unauthenticated) before returning the token fix(fresh): wait for initial storage read before returning token Jul 20, 2024
@felangel felangel added the bug Something isn't working label Jul 20, 2024
Copy link
Owner

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the fix!

@felangel felangel merged commit 2157185 into felangel:master Jul 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants