(add) runtime: generate correct code for identifier-index; implement …

…`String.prototype.concat`

src/bali/runtime/interpreter.nim

@@ -327,8 +327,8 @@ proc generateIR*(
     else:
       runtime.ir.returnFn(runtime.index(&stmt.retIdent, defaultParams(fn)).int)
   of CallAndStoreResult:
-    runtime.markLocal(fn, stmt.storeIdent)
     runtime.generateIR(fn, stmt.storeFn)
+    runtime.markLocal(fn, stmt.storeIdent)
 
     let index = runtime.index(stmt.storeIdent, defaultParams(fn))
     debug "emitter: call-and-store result will be stored in ident \"" & stmt.storeIdent &
@@ -692,7 +692,11 @@ proc generateIR*(
       runtime.ir.call(normalizeIRName "console.log")
   of AccessArrayIndex:
     let atomIdx = runtime.index(stmt.arrAccIdent, defaultParams(fn))
-    let fieldIndex = runtime.loadIRAtom(stmt.arrAccIndex)
+    let fieldIndex = if *stmt.arrAccIndex:
+      runtime.loadIRAtom(&stmt.arrAccIndex)
+    elif *stmt.arrAccIdentIndex:
+      runtime.index(&stmt.arrAccIdentIndex, defaultParams(fn))
+    else: unreachable; 0
 
     runtime.ir.passArgument(atomIdx)
     runtime.ir.passArgument(fieldIndex)

src/bali/stdlib/types/std_string.nim

@@ -86,6 +86,36 @@ proc generateStdIr*(runtime: Runtime) =
       ret search.find(value[start ..< value.len], searchStr)
   )
 
+  runtime.definePrototypeFn(
+    JSString, "concat",
+    proc(value: MAtom) =
+      ## 22.1.3.5 String.prototype.concat ( ...args )
+
+      # 1. Let O be ? RequireObjectCoercible(this value).
+      # 2. Let S be ? ToString(O).
+      let value = runtime.ToString(
+        runtime.RequireObjectCoercible(&value.tagged("internal"))
+      )
+
+      # 3. Let R be S.
+      var res = value
+
+      # 4. For each element next of args, do
+      for i in 0 ..< runtime.argumentCount():
+        # a. Let nextString be ? ToString(next).
+        let nextString = runtime.ToString(
+          &runtime.argument(i + 1)
+        )
+
+        # b. Set R to the string-concatenation of R and nextString.
+        res &= nextString
+
+      # 5. Return R.
+      echo runtime.argumentcount
+      echo res
+      ret res
+  )
+
   runtime.definePrototypeFn(
     JSString,
     "trim",

tests/data/index-ident-001.js

@@ -0,0 +1,9 @@
+var i = 0;
+var list = ["A", "B", "C"]
+
+while (i < 2)
+{
+	let val = list[i]
+	console.log(val)
+	i++
+}

tests/data/string-concat-001.js

@@ -0,0 +1,15 @@
+let x = new String("hello ")
+let vals = [
+	"world",
+	"nerds",
+	"folks",
+	"readers"
+]
+var i = 0
+
+while (i < 4)
+{
+	let val = vals[i]
+	console.log(x.concat(val))
+	i++
+}