-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/bug-fix: add maxParallelUploads option to FileUpload component #15309
feat/bug-fix: add maxParallelUploads option to FileUpload component #15309
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code is perfect, thank you very much for adhering to the style of the rest of the codebase
After these changes I get an error:
A field without multiple uploads. |
Could you create a reproduction repository please? I can't imagine why that would be the case. |
Sorry, the reason is not in these changes, but in another package that substitutes the source classes, as a result of which this error occurs: joshembling/image-optimizer#38 |
All my forms that has file uploads got this error: |
I’m having this error too. |
Could you create a reproduction repository please? I can't imagine why that would be the case. |
I ran composer update, then I got this error |
After the update, I encountered the error "Undefined variable $getMaxParallelUploads" in all forms that involve file uploads, including the Import action. Update: The issue was resolved by removing the "joshembling/image-optimizer" package. |
It does seem like this plugin is causing the issues. It is using the Filament file upload view, but not extending the |
Anyone got a workaround? |
Remove |
Description
This pull request adds a
maxParallelUploads()
method to control how many parallel uploads happen at once.Although this is a useful method by itself, it also allows a simple workaround for #15308
Visual changes
There are no visible changes except for the documentation, which is highlighted in red.
Functional changes
composer cs
command.