Scala 2.12 upgrade #1162
Merged
Scala 2.12 upgrade #1162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aandis
force-pushed
the
scala-2.12
branch
3 times, most recently
from
c781d78 to
1b8fbf9
Compare
There was a problem hiding this comment.
Could you please address the one comment I added? Rest looks good.
Can we also run one JMH benchmark to confirm that things look good there.
We also need to bring up two servers locally, ingest and query synthetic data generated by GatewayServer test data producer
|
@aandis Please rebase, ensure that PRB runs successfully. |
|
@aandis Please do not squash and merge, Instead retain individual commits. |
|
Ha ha, I already lost hope it will land. 🤝 |
|
@szymonm We had to time this PR since we were in the process of stabilizing the mainline. This PR will need some rigorous integration testing and we had to make room for it. Hence the delay. Thanks for the patience! 🙏 |
|
Closing and reopening to trigger ci. |
added 18 commits
August 7, 2021 10:20
Scala 2.12 deprecates ranges on doubles.
Breaking changes: This possible breaks cryo serialization backwards compat.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to #870 with a rebase on current
develop.[x] Changes verified locally.
[x] Code compiles successfully.
[x] All tests are passing.
[x] Filodb server comes up.
[x] Can see dummy data with
TestTimeseriesProducer.Pull Request checklist
NOTICEABLE CHANGES
c781d78 is the only change on top of #870 that needs to be reviewed.