feat(histogram): add meaningful exception when histograms add buckets with different sizes #1880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please follow the guidelines for PR descriptions ( look at the previous closed PRs for reference as well) |
Boyuan-Yu
changed the title
Thanks for the reminder. It's updated. |
yu-shipit
reviewed
Nov 8, 2024
memory/src/main/scala/filodb.memory/format/vectors/Histogram.scala
Outdated
Show resolved
Hide resolved
…cala Co-authored-by: yu-shipit <[email protected]>
yu-shipit
approved these changes
Nov 12, 2024
memory/src/main/scala/filodb.memory/format/vectors/Histogram.scala
Outdated
Show resolved
Hide resolved
sandeep6189
reviewed
Nov 13, 2024
| assert(other.buckets == buckets) | ||
| if (other.buckets != buckets) { | ||
| throw new IllegalArgumentException( | ||
| "Mismatch in bucket sizes. Cannot add histograms with different bucket configurations." |
There was a problem hiding this comment.
nitpick: buckets size could also be same, but the bucket configurations might be different
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
Current behavior : when histograms add buckets with different sizes, it returns a 5xx error
New behavior : it returns an IllegalArgumentException with a meaningful message