Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc: update ficus and akka-kryo to 2.12 supported version #835

Merged
merged 3 commits into from
Aug 3, 2020
Merged

misc: update ficus and akka-kryo to 2.12 supported version #835

merged 3 commits into from
Aug 3, 2020

Conversation

szymonm
Copy link
Contributor

@szymonm szymonm commented Jul 30, 2020 •
edited
Loading

Pull Request checklist

  • The commit(s) message(s) follows the contribution guidelines ?
  • Tests for the changes have been added (for bug fixes / features) ?
  • Docs have been added / updated (for bug fixes / features) ?

Current behavior :

Updating to versions that are supported by both Scala 2.11 and 2.12 (issue #457 )

velvia
velvia approved these changes Aug 1, 2020
View reviewed changes
Copy link
Member

@velvia velvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me, please rebase/merge with latest and I'll merge. Thanks again @szymonm

@szymonm szymonm force-pushed the scala12ficusakkakryo branch from 426f440 to dd81356 Compare August 3, 2020 08:26
@szymonm
Copy link
Contributor Author

szymonm commented Aug 3, 2020

Rebased.

@velvia velvia merged commit 9fcd530 into filodb:develop Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@velvia velvia velvia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@szymonm @velvia