Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creation of Global Markdown Formatting and Linting GitHub Actions #223

Merged
merged 21 commits into from
Jul 23, 2024

Conversation

damienjburks
Copy link
Contributor

@damienjburks damienjburks commented Jun 25, 2024

Summary

PSA: It may look like a pretty beefy PR, but it isn't. Most of the added/deleted lines are due to formatting and linting fixes. 😉

I am introducing the GitHub Actions for linting and formatting all Markdown files within the project using markdownlint-cli and prettier. To get this GitHub Action to pass, I had to format and lint each Markdown file. I have also disabled quite a few rules for markdownlint-cli & prettier to conserve the current structure for referencing images and other forms of content.

You can view all of the disabled & enabled rules for markdownlint-cli in .config/.markdownlint-cli.yaml, and prettier in .config/.prettierrc file.

In addition, there is an end-user guide for everyone who uses VS Code on how to install and configure the extensions for easier formatting and linting, which is located here: docs/training/lint_format_user_guide.md

Linked issues

Supported Links

@damienjburks damienjburks marked this pull request as ready for review June 27, 2024 23:38
@damienjburks damienjburks requested review from a team as code owners June 27, 2024 23:38
@damienjburks damienjburks requested review from a team June 29, 2024 00:01
Copy link
Contributor

@eddie-knight eddie-knight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from two changes, this looks good to go.

.github/ISSUE_TEMPLATE/bug_report.md Outdated Show resolved Hide resolved
docs/training/Readme.md Outdated Show resolved Hide resolved
services/database-services.md Show resolved Hide resolved
@damienjburks
Copy link
Contributor Author

damienjburks commented Jul 20, 2024

Okay @eddie-knight we should be good to go now. Everything has been resolved and corrected. Also, I did ask @mlysaght2017 if he'd be an additional reviewer for delivery WG for PRs, and he agreed to do so until we get some more folks involved. Are you fine with that?

@eddie-knight
Copy link
Contributor

Absolutely. Please update the GitHub issue when you action that!

@eddie-knight
Copy link
Contributor

@smendis-scottlogic and @mlysaght2017 please review & approve to unlock the merge button on this PR.

To help streamline your approval, I've reviewed all of the files changed and confirmed that there are no impactful changes. Where polish was possible, I have left comments that are all now resolved.

@eddie-knight
Copy link
Contributor

@TheJuanAndOnly99 I'm not sure why this isn't able to be merged, do you have any ideas?

@damienjburks
Copy link
Contributor Author

@eddie-knight i seems as if I'm able to merge this in. Would you like me to do so?

@eddie-knight
Copy link
Contributor

Yeah! Letsgoooo

@damienjburks damienjburks merged commit 2a47586 into finos:main Jul 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delivery Work related to the Delivery WG
Projects
None yet
3 participants