-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creation of Global Markdown Formatting and Linting GitHub Actions #223
Conversation
Signed-off-by: Damien Burks <[email protected]>
74767cb
to
992a191
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from two changes, this looks good to go.
Co-authored-by: Eddie Knight <[email protected]>
docs/governance/community-guidelines/content-standards-and-practices/README.md
Outdated
Show resolved
Hide resolved
… issue for this to be fixed
Okay @eddie-knight we should be good to go now. Everything has been resolved and corrected. Also, I did ask @mlysaght2017 if he'd be an additional reviewer for delivery WG for PRs, and he agreed to do so until we get some more folks involved. Are you fine with that? |
Absolutely. Please update the GitHub issue when you action that! |
Co-authored-by: Eddie Knight <[email protected]>
@smendis-scottlogic and @mlysaght2017 please review & approve to unlock the merge button on this PR. To help streamline your approval, I've reviewed all of the files changed and confirmed that there are no impactful changes. Where polish was possible, I have left comments that are all now resolved. |
@TheJuanAndOnly99 I'm not sure why this isn't able to be merged, do you have any ideas? |
@eddie-knight i seems as if I'm able to merge this in. Would you like me to do so? |
Yeah! Letsgoooo |
Summary
I am introducing the GitHub Actions for linting and formatting all Markdown files within the project using markdownlint-cli and prettier. To get this GitHub Action to pass, I had to format and lint each Markdown file. I have also disabled quite a few rules for markdownlint-cli & prettier to conserve the current structure for referencing images and other forms of content.
You can view all of the disabled & enabled rules for markdownlint-cli in
.config/.markdownlint-cli.yaml
, and prettier in.config/.prettierrc file.
In addition, there is an end-user guide for everyone who uses VS Code on how to install and configure the extensions for easier formatting and linting, which is located here:
docs/training/lint_format_user_guide.md
Linked issues
Supported Links