Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lychee as a link checker. #283

Merged
merged 2 commits into from
Jul 29, 2024
Merged

Conversation

dogle-scottlogic
Copy link
Contributor

Add lychee as a link checker.
Standardise on kebab case for job names

@damienjburks
Copy link
Contributor

damienjburks commented Jul 29, 2024

@dogle-scottlogic add this anywhere under line 7 inside of the pr_workflow.yml file:

link-checker:
      uses: ./.github/workflows/links.yml
      permissions:
        pull-requests: write
        contents: read

@damienjburks damienjburks self-requested a review July 29, 2024 14:20
Copy link
Contributor

@damienjburks damienjburks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@damienjburks damienjburks linked an issue Jul 29, 2024 that may be closed by this pull request
@damienjburks
Copy link
Contributor

@sshiells-scottlogic & @eddie-knight are we good to merge?

@eddie-knight
Copy link
Contributor

Sure, we can merge now and adjust later if needed.

Thanks for this @dogle-scottlogic !

@eddie-knight eddie-knight merged commit 567d6d7 into finos:main Jul 29, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link Checking
4 participants