Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Object Storage development files from MD to YAML #301

Closed
wants to merge 11 commits into from

Conversation

eddie-knight
Copy link
Contributor

Part of #299.

This PR transforms the Object Storage taxonomy, threats, and controls from markdown into yaml files.

@eddie-knight eddie-knight requested review from a team as code owners August 5, 2024 16:44
mlysaght2017
mlysaght2017 previously approved these changes Aug 5, 2024
Copy link
Contributor

@mlysaght2017 mlysaght2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

damienjburks
damienjburks previously approved these changes Aug 5, 2024
Copy link
Contributor

@damienjburks damienjburks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'm excited 🚀

@eddie-knight
Copy link
Contributor Author

@smendis-scottlogic Could you take a look at this? The idea is to start moving content into YAML format, then we can use the generator (different PR) to craft Markdown documents at release time.

@robmoffat robmoffat mentioned this pull request Aug 15, 2024
13 tasks
Signed-off-by: Eddie Knight <[email protected]>
Copy link
Contributor

@mlysaght2017 mlysaght2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eddie-knight - this looks great. I think we just need to add a reference to "threat" as discussed

I'm thinking a control family reference would be useful here too.

@eddie-knight eddie-knight requested a review from a team as a code owner August 29, 2024 15:57
@eddie-knight
Copy link
Contributor Author

@mlysaght2017 please review to make sure I've made all of the updates we discussed

Signed-off-by: Eddie Knight <[email protected]>
Copy link
Contributor

@sshiells-scottlogic sshiells-scottlogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mlysaght2017
Copy link
Contributor

We'll need control_family and threats added too to align to the new template. Happy to approve and get those in later though.

@eddie-knight
Copy link
Contributor Author

Thanks for catching that @mlysaght2017, I'll put up another commit shortly

Signed-off-by: Eddie Knight <[email protected]>
Signed-off-by: Eddie Knight <[email protected]>
damienjburks
damienjburks previously approved these changes Aug 29, 2024
mlysaght2017
mlysaght2017 previously approved these changes Aug 30, 2024
@eddie-knight
Copy link
Contributor Author

Closing this as the required reviewers has gotten wonky.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants