-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert Object Storage development files from MD to YAML #301
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I'm excited 🚀
Signed-off-by: Eddie Knight <[email protected]>
Signed-off-by: Eddie Knight <[email protected]>
Signed-off-by: Eddie Knight <[email protected]>
90817d8
@smendis-scottlogic Could you take a look at this? The idea is to start moving content into YAML format, then we can use the generator (different PR) to craft Markdown documents at release time. |
Signed-off-by: Eddie Knight <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eddie-knight - this looks great. I think we just need to add a reference to "threat" as discussed
I'm thinking a control family reference would be useful here too.
Signed-off-by: Eddie Knight <[email protected]>
@mlysaght2017 please review to make sure I've made all of the updates we discussed |
Signed-off-by: Eddie Knight <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We'll need |
Thanks for catching that @mlysaght2017, I'll put up another commit shortly |
Signed-off-by: Eddie Knight <[email protected]>
Signed-off-by: Eddie Knight <[email protected]>
Signed-off-by: Eddie Knight <[email protected]>
Signed-off-by: Eddie Knight <[email protected]>
Closing this as the required reviewers has gotten wonky. |
Part of #299.
This PR transforms the Object Storage taxonomy, threats, and controls from markdown into yaml files.