change(control): Typofixes and new tests for RDMS #617
+42
−113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te. Removed outdated markdown file Corrected typos, Added additional tests
|
Hallelujah! finally a PR that passes the EasyCLA check on all (1) commits! |
|
Thanks for this @shoffman-percona! @robmoffat — I'm surprised to see netlify running on this PR. Could you look into this? |
|
thanks @shoffman-percona! Can you please ensure the lint-checker passes also. |
|
@mlysaght2017 — The link checker was reporting a failure from the OSCAL training resource, on the gitter url. That link seemed functional when I looked, so I just hit the button to re-run the job and it's passing fine now. @damienjburks / @finos/ccc-wg-delivery — We'll need to circle back to the link checker to ensure it only evaluates changed files in the future. |
eddie-knight
changed the title
damienjburks
approved these changes
Jan 14, 2025
mlysaght2017
approved these changes
Jan 16, 2025
|
@mlysaght2017 do we want to adjust the CODEOWNERS file so that it doesn't require a review from Taxonomy WG? |
smendis-scottlogic
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed outdated markdown file
Corrected typos, Added additional tests
Also squashed changes to single commit to address incorrect name/email for CLA check.