Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): Add pr-title workflow #619

Merged
merged 1 commit into from
Jan 11, 2025

Conversation

jmeridth
Copy link
Contributor

Closes #618

  • verify PR title is adhering to designed scopes and types

Closes finos#618

- [x] verify PR title is adhering to designed scopes and types

Signed-off-by: jmeridth <[email protected]>
@jmeridth jmeridth requested a review from a team as a code owner January 11, 2025 07:42
Copy link

linux-foundation-easycla bot commented Jan 11, 2025

CLA Signed


The committers listed above are authorized under a signed CLA.

Copy link

netlify bot commented Jan 11, 2025

Deploy Preview for common-cloud-controls failed. Why did it fail? →

Name Link
🔨 Latest commit 3393463
🔍 Latest deploy log https://app.netlify.com/sites/common-cloud-controls/deploys/678220eb679dd90008bdafd7

Copy link
Contributor

@damienjburks damienjburks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a run for this. Isn't this supposed to run on this PR as well?

@jmeridth
Copy link
Contributor Author

I don't see a run for this. Isn't this supposed to run on this PR as well?

Unfortunately it has to be on the default branch to run. Chicken/egg problem.

I did test it here re: scope if that helps.

@eddie-knight
Copy link
Contributor

@robmoffat I'm surprised to see netlify running on this PR— it seems to be a configuration set at the admin level beyond the scope the project maintainers can control. Can you please investigate?

Copy link
Contributor

@damienjburks damienjburks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the work!

@damienjburks damienjburks merged commit 473c288 into finos:main Jan 11, 2025
7 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add PR Title checks to improve repo history / change log
3 participants