Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Auth] Refactor MultiFactor.swift #14241

Merged
merged 6 commits into from
Jan 6, 2025
Merged

[Auth] Refactor MultiFactor.swift #14241

merged 6 commits into from
Jan 6, 2025

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Dec 10, 2024 •
edited
Loading

Manual tests:

  • Phone MFA login
  • TOTP MFA login

#no-changelog

@ncooke3 ncooke3 marked this pull request as ready for review January 4, 2025 00:50
@ncooke3 ncooke3 added this to the 11.7.0 - M158 milestone Jan 4, 2025
paulb777
paulb777 approved these changes Jan 4, 2025
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider my comments optional, since this is already a good step forward.

FirebaseAuth/Sources/Swift/MultiFactor/MultiFactor.swift Show resolved Hide resolved
FirebaseAuth/Sources/Swift/MultiFactor/MultiFactor.swift Outdated Show resolved Hide resolved
@ncooke3
Copy link
Member Author

ncooke3 commented Jan 6, 2025

Great ideas, thanks @paulb777. I have a note in my Firebase 12 API improvements doc about improving the MFA API with an enum or similar to make switching over MFA types easier.

@ncooke3 ncooke3 merged commit c092c02 into main Jan 6, 2025
55 checks passed
@ncooke3 ncooke3 deleted the nc/multifactor-refactor branch January 6, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
api: auth
Projects
None yet
Milestone
11.7.0 - M158
Development

Successfully merging this pull request may close these issues.
3 participants
@ncooke3 @paulb777 @google-oss-bot