Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firestore: add a test for formatting an objective-c Class objects #14328

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Jan 9, 2025

Add a test for formatting an objective-c Class object instring_format_apple_test.mm. The test suite previously covered formatting Objective-C objects, but not the specific override for formatting Class objects. With this PR, the tests were improved to also cover this missing case.

#no-changelog

@dconeybe dconeybe self-assigned this Jan 9, 2025
@dconeybe dconeybe merged commit 52d9152 into main Jan 10, 2025
35 checks passed
@dconeybe dconeybe deleted the dconeybe/StringFormatObjCClassTest branch January 10, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants