Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support varlen training for conv1d #116

Merged
merged 2 commits into from
Jan 12, 2025
Merged

support varlen training for conv1d #116

merged 2 commits into from
Jan 12, 2025

Conversation

LKJacky
Copy link

@LKJacky LKJacky commented Jan 10, 2025

support varlen training for conv1d

add seq_idx arg to ShortConv1d
modify several modeling which supports varlen rnn kernel

@yzhangcs
Copy link
Member

@LKJacky Hello, thank you for your nice contributions.
Have you checked this impls, making it runnable by python benchmark_training_throughput.py --name delta_net.

I can't find APIs for seq_idx in causal_conv1d_fn

@LKJacky
Copy link
Author

LKJacky commented Jan 10, 2025

Yes, I have tested it. It works fine.

@sustcsonglin sustcsonglin merged commit 042af84 into fla-org:main Jan 12, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants