Go 1.22

.github/workflows/checks.yml

@@ -14,7 +14,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v3
         with:
-          go-version: ^1.21
+          go-version: ^1.22
         id: go
 
       - name: Check out code into the Go module directory
@@ -30,20 +30,20 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v3
         with:
-          go-version: ^1.21
+          go-version: ^1.22
         id: go
 
       - name: Check out code into the Go module directory
         uses: actions/checkout@v2
 
       - name: Install gofumpt
-        run: go install mvdan.cc/gofumpt@v0.4.0
+        run: go install mvdan.cc/gofumpt@v0.6.0
 
       - name: Install staticcheck
-        run: go install honnef.co/go/tools/cmd/[email protected].2
+        run: go install honnef.co/go/tools/cmd/[email protected].6
 
       - name: Install golangci-lint
-        run: go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.54.2
+        run: go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.56.1
 
       - name: Lint
         run: make lint

.golangci.yaml

@@ -28,6 +28,7 @@ linters:
     - varcheck
     - depguard
     - exhaustruct
+    - perfsprint
 
     #
     # Disabled because of generics:

collector/node_conn_bloxroute.go

@@ -131,7 +131,7 @@ func (nc *BlxNodeConnection) connect() {
 
 		// fmt.Println("got message", string(nextNotification))
 		var txMsg common.BlxRawTxMsg
-		err = json.Unmarshal(nextNotification, &txMsg)
+		err = json.Unmarshal(nextNotification, &txMsg) //nolint:musttag
 		if err != nil {
 			nc.log.Errorw("failed to unmarshal message", "error", err)
 			continue

collector/node_conn_eden.go

@@ -129,7 +129,7 @@ func (nc *EdenNodeConnection) connect() {
 
 		// fmt.Println("got message", string(nextNotification))
 		var txMsg common.EdenRawTxMsg
-		err = json.Unmarshal(nextNotification, &txMsg)
+		err = json.Unmarshal(nextNotification, &txMsg) //nolint:musttag
 		if err != nil {
 			nc.log.Errorw("failed to unmarshal message", "error", err)
 			continue

common/common_test.go

@@ -100,7 +100,7 @@ func TestParquet(t *testing.T) {
 	pr.ReadStop()
 	fr.Close()
 
-	require.Equal(t, 1, len(entries))
+	require.Len(t, entries, 1)
 	tx := entries[0]
 
 	require.Equal(t, summary.Timestamp, tx.Timestamp)

common/txsfile.go

@@ -4,7 +4,6 @@ import (
 	"archive/zip"
 	"bufio"
 	"errors"
-	"fmt"
 	"io"
 	"os"
 	"strconv"
@@ -184,8 +183,8 @@ func ParseTx(timestampMs int64, rawTxHex string) (TxSummaryEntry, *types.Transac
 		From:      strings.ToLower(from.Hex()),
 		To:        strings.ToLower(to),
 		Value:     tx.Value().String(),
-		Nonce:     fmt.Sprint(tx.Nonce()),
-		Gas:       fmt.Sprint(tx.Gas()),
+		Nonce:     strconv.FormatUint(tx.Nonce(), 10),
+		Gas:       strconv.FormatUint(tx.Gas(), 10),
 		GasPrice:  tx.GasPrice().String(),
 		GasTipCap: tx.GasTipCap().String(),
 		GasFeeCap: tx.GasFeeCap().String(),

common/txsummary.go

@@ -4,6 +4,7 @@ import (
 	"context"
 	"fmt"
 	"math"
+	"strconv"
 	"strings"
 
 	"github.com/ethereum/go-ethereum/common"
@@ -110,23 +111,23 @@ func (t *TxSummaryEntry) WasIncludedBeforeReceived() bool {
 
 func (t *TxSummaryEntry) ToCSVRow() []string {
 	return []string{
-		fmt.Sprint(t.Timestamp),
+		strconv.FormatInt(t.Timestamp, 10),
 		t.Hash,
 		t.ChainID,
 		t.From,
 		t.To,
 		t.Value,
-		fmt.Sprint(t.Nonce),
-		fmt.Sprint(t.Gas),
+		t.Nonce,
+		t.Gas,
 		t.GasPrice,
 		t.GasTipCap,
 		t.GasFeeCap,
-		fmt.Sprint(t.DataSize),
+		strconv.FormatInt(t.DataSize, 10),
 		t.Data4Bytes,
 		strings.Join(t.Sources, " "),
-		fmt.Sprint(t.IncludedAtBlockHeight),
-		fmt.Sprint(t.IncludedBlockTimestamp),
-		fmt.Sprint(t.InclusionDelayMs),
+		strconv.FormatInt(t.IncludedAtBlockHeight, 10),
+		strconv.FormatInt(t.IncludedBlockTimestamp, 10),
+		strconv.FormatInt(t.InclusionDelayMs, 10),
 	}
 }
 

common/types.go

@@ -4,15 +4,15 @@ import (
 	"strings"
 )
 
-type BlxRawTxMsg struct { //nolint:musttag
+type BlxRawTxMsg struct {
 	Params struct {
 		Result struct {
 			RawTx string
 		}
 	}
 }
 
-type EdenRawTxMsg struct { //nolint:musttag
+type EdenRawTxMsg struct {
 	Params struct {
 		Result struct {
 			RLP string

go.mod

@@ -1,6 +1,6 @@
 module github.com/flashbots/mempool-dumpster
 
-go 1.21
+go 1.22
 
 require (
 	github.com/HdrHistogram/hdrhistogram-go v1.1.2