Fix test failure caused by missing files in the tarball release #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smcv
force-pushed
the
installed-tests
branch
2 times, most recently
from
bb76514 to
b94b69a
Compare
smcv
changed the title
Otherwise, the tests will fail when built from the dist tarball. Also install it if "as-installed" tests are enabled, so that it can be used in those tests too. Resolves: flatpak#585 Signed-off-by: Simon McVittie <[email protected]>
Signed-off-by: Simon McVittie <[email protected]>
smcv
force-pushed
the
installed-tests
branch
from
b94b69a to
08c2a88
Compare
smcv
changed the title
|
Would you like a 1.4.2 with this fix? |
|
It might make sense to have a new release for this and d9f5a5e. For now I applied both as patches in Debian. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tests: Ensure all test files are in the dist tarball
Otherwise, the tests will fail when built from the dist tarball.
Also install it if "as-installed" tests are enabled, so that it can be
used in those tests too.
Resolves: test-rename-appdata.json missing from flatpak-builder-1.4.1.tar.xz #585
workflows: Exercise
make distcheckin CITo reproduce (1): unpack
flatpak-builder-1.4.1.tar.xz,autoreconf -fi && ./configure && make && make install. (#585)To reproduce (2): install https://gitlab.gnome.org/GNOME/gnome-desktop-testing, build with
-Dinstalled_tests=true, install, rungnome-desktop-testing-runner flatpak-builder. We use this in the Debian packaging, to catch potential bugs where upgrading a dependency might break flatpak-builder.