This repository has been archived by the owner on Dec 17, 2024. It is now read-only.
Improve support for armbian based images #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace custom releaseinfochange module with pkgupgrade module from CustomPiOS which does the same thing.
Armbian based images don't allow passwordless sudo by default, making the sudo_fix.sh script from moonraker fail as it can't obtain a password.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve/fix the building of FluiddPi images based off Armbian
releaseinfochange module isn't handling changes to configuration files well,
prompting for user input during the build process. The CustomPiOS module
pkgupgrade provides the same functionality and handles user input requests
better.
The Moonraker sudo_fix.sh script is broken when the user doesn't have
password-less sudo enabled. Ensure that the pi user can sudo without
prompting for a password for the duration of the build process.
Building variants uses different image and workspace directories, cover
these in the .gitignore rules.