Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add onCancelCallback, onFailureCallback in LLM Chat View #38

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ONLYstcm
Copy link

  • Added onCancelCallback to allow complete replacement of the default behavior of AdaptiveSnackBar when an LlmCancelException occurs.
  • Added onFailureCallback to enable overriding the default behavior of AdaptiveAlertDialog for LlmFailureException and general LlmException.
  • Added cancelMessage to allow CANCEL message to be changed when an LlmCancelException occurs.
  • Added errorMessage to allow ERRORz message to be changed when an LlmCancelException` occurs.

Implements: #37

Copy link

google-cla bot commented Dec 25, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@csells
Copy link
Contributor

csells commented Dec 26, 2024

@ONLYstcm please include a new sample that shows off this capability.

Copy link
Contributor

@domesticmouse domesticmouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ONLYstcm Please sign the CLA. We can't merge the PR without it

@ONLYstcm
Copy link
Author

@csells @domesticmouse Please take a look now 🙏

@domesticmouse domesticmouse dismissed their stale review December 28, 2024 20:16

CLA now signed

Copy link
Contributor

@domesticmouse domesticmouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL @csells

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants