Remove the Raster Stats feature from the Performance page. (#7981)

flutter · Jun 26, 2024 · 1e79aed · 1e79aed
1 parent 8f9879c
commit 1e79aed
Show file tree

Hide file tree

Showing 26 changed files with 30 additions and 10,112 deletions.
diff --git a/packages/devtools_app/lib/devtools_app.dart b/packages/devtools_app/lib/devtools_app.dart
@@ -40,7 +40,6 @@ export 'src/screens/performance/panes/flutter_frames/flutter_frame_model.dart';
 export 'src/screens/performance/panes/flutter_frames/flutter_frames_chart.dart';
 export 'src/screens/performance/panes/flutter_frames/flutter_frames_controller.dart';
 export 'src/screens/performance/panes/frame_analysis/frame_analysis_model.dart';
-export 'src/screens/performance/panes/raster_stats/raster_stats_controller.dart';
 export 'src/screens/performance/panes/rebuild_stats/rebuild_stats_controller.dart';
 export 'src/screens/performance/panes/rebuild_stats/rebuild_stats_model.dart';
 export 'src/screens/performance/panes/timeline_events/perfetto/tracing/model.dart';

diff --git a/packages/devtools_app/lib/src/screens/performance/panes/frame_analysis/frame_hints.dart b/packages/devtools_app/lib/src/screens/performance/panes/frame_analysis/frame_hints.dart
@@ -67,7 +67,7 @@ class FrameHints extends StatelessWidget {
             if (frame.hasShaderTime)
               ShaderCompilationHint(shaderTime: frame.shaderDuration),
             const SizedBox(height: denseSpacing),
-            const RasterStatsHint(),
+            const GeneralRasterJankHint(),
           ]
         : <Widget>[];
 
@@ -386,8 +386,8 @@ class ShaderCompilationHint extends StatelessWidget {
 }
 
 @visibleForTesting
-class RasterStatsHint extends StatelessWidget {
-  const RasterStatsHint({super.key});
+class GeneralRasterJankHint extends StatelessWidget {
+  const GeneralRasterJankHint({super.key});
 
   @override
   Widget build(BuildContext context) {
@@ -397,16 +397,22 @@ class RasterStatsHint extends StatelessWidget {
         text: TextSpan(
           children: [
             TextSpan(
-              text: 'Consider using the',
+              text: 'To learn about rendering performance in Flutter, check '
+                  'out the Flutter documentation on ',
               style: theme.regularTextStyle,
             ),
-            TextSpan(
-              text: ' Raster Stats ',
-              style: theme.subtleFixedFontStyle,
+            GaLinkTextSpan(
+              link: GaLink(
+                display: 'Performance & Optimization',
+                url: flutterPerformanceDocsUrl,
+                gaScreenName: gac.performance,
+                gaSelectedItemDescription:
+                    gac.PerformanceDocs.flutterPerformanceDocs.name,
+              ),
+              context: context,
             ),
             TextSpan(
-              text: 'tab to identify rendering layers that are expensive to '
-                  'rasterize.',
+              text: '.',
               style: theme.regularTextStyle,
             ),
           ],