This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanprodan
force-pushed
the
archival
branch
from
November 1, 2022 10:29
b0ffbe0
to
57f1690
Compare
dholbach
reviewed
Nov 1, 2022
stefanprodan
force-pushed
the
archival
branch
from
November 1, 2022 10:35
57f1690
to
b1fb141
Compare
hiddeco
reviewed
Nov 1, 2022
dholbach
approved these changes
Nov 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nicely written, thanks @stefanprodan
stefanprodan
force-pushed
the
archival
branch
2 times, most recently
from
November 1, 2022 10:43
685ea61
to
065f1d3
Compare
pjbgf
approved these changes
Nov 1, 2022
hiddeco
approved these changes
Nov 1, 2022
Good from my perspective |
darkowlzz
approved these changes
Nov 1, 2022
kingdonb
approved these changes
Nov 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with one suggested change 👍
stefanprodan
force-pushed
the
archival
branch
2 times, most recently
from
November 1, 2022 11:54
643a9fc
to
3b639bc
Compare
Signed-off-by: Stefan Prodan <[email protected]>
stefanprodan
force-pushed
the
archival
branch
from
November 1, 2022 12:38
3b639bc
to
d192208
Compare
This was referenced Nov 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update readme to reflect Flux v1 EOL, its successor and project history.
Closes: #3645