Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msteams notifier: adaptive cards full width #1017

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

vflaux
Copy link
Contributor

@vflaux vflaux commented Jan 14, 2025

In teams notifications, configure the adaptive card to expand and make full use of extra canvas space by setting the msteams.width property to Full (https://learn.microsoft.com/en-us/microsoftteams/platform/task-modules-and-cards/cards/cards-format?tabs=adaptive-md%2Cdesktop%2Cdesktop1%2Cdesktop2%2Cconnector-html#full-width-adaptive-card).

This allow the card to be wider and more similar to the legacy message card version.

This is an implementation of the point 1 in #956.

Before:
image

After:
image

Configure the adaptive card to expand and make full use of extra canvas
space in teams.

Signed-off-by: Valentin Flaux <[email protected]>
Copy link
Member

@matheuscscp matheuscscp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vflaux! By seeing the screenshot I assume you were able to build an image and test this e2e?

@vflaux
Copy link
Contributor Author

vflaux commented Jan 15, 2025

Yes, I did build an image and deployed it in a cluster.

@stefanprodan stefanprodan added the area/alerting Alerting related issues and PRs label Jan 15, 2025
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Nice improvement, thanks @vflaux

@matheuscscp
Copy link
Member

Thanks very much @vflaux! Nice contribution :)

@matheuscscp matheuscscp merged commit 5469e2a into fluxcd:main Jan 15, 2025
7 checks passed
@vflaux vflaux deleted the teams_adaptive_cards_full_width branch January 15, 2025 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/alerting Alerting related issues and PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants