Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add new version of apex language server #5225

Merged
merged 4 commits into from
Nov 15, 2023

Conversation

peternhale
Copy link
Contributor

Adds deadlock detection to LS

@W-14463118@

@W-14463118@

Adds deadlock dection to LS
@peternhale peternhale requested a review from a team as a code owner November 9, 2023 18:15
@diyer
Copy link
Collaborator

diyer commented Nov 9, 2023

@peternhale do we get telemetry events generated for deadlocks that can help us gather data from customer usages?

@peternhale
Copy link
Contributor Author

@peternhale do we get telemetry events generated for deadlocks that can help us gather data from customer usages?

@diyer yes. that code is included on the Java side.

@diyer
Copy link
Collaborator

diyer commented Nov 9, 2023

@peternhale do we get telemetry events generated for deadlocks that can help us gather data from customer usages?

@diyer yes. that code is included on the Java side.

@peternhale cool! ty. my bad, I skimmed through the PR but did not go over in detail.

Copy link
Contributor

@CristiCanizales CristiCanizales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
QE notes here

@peternhale peternhale merged commit dc82213 into develop Nov 15, 2023
8 of 9 checks passed
@peternhale peternhale deleted the phale/W-14463118-ls-with-deadlocks branch November 15, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants