fix: org create command to sf style #5295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peternhale
approved these changes
Dec 28, 2023
…dotcom/salesforcedx-vscode into cristi/w-14700670/org-create-to-sf
daphne-sfdc
reviewed
Jan 3, 2024
Comment on lines
60
to
+65
|
|
||
| public withJson(): CommandBuilder { | ||
| public withJson(logLevel: boolean = true): CommandBuilder { | ||
| this.args.push('--json'); | ||
| this.args.push('--loglevel', 'fatal'); | ||
| if (logLevel) { | ||
| this.args.push('--loglevel', 'fatal'); | ||
| } |
There was a problem hiding this comment.
Since we are now using the SF_LOG_LEVEL environment variable instead of the deprecated --loglevel flag, is this change necessary? Or is it ok to just take out the --loglevel flag entirely?
There was a problem hiding this comment.
that flag is still used in other commands, so I'd keep it until the very last moment when we actually change from sfdx to sf or when no other commands are left to be transitioned
daphne-sfdc
reviewed
Jan 3, 2024
| .withArg('org:create:scratch') | ||
| .withFlag('--definition-file', `${scratchDefFilePath}`) | ||
| .withArg('--set-default') | ||
| .withJson(false) |
There was a problem hiding this comment.
Why don't we want JSON anymore?
There was a problem hiding this comment.
we want it, the false is just to evaluate the addition of --loglevel
daphne-sfdc
reviewed
Jan 3, 2024
| const createCommand = forceOrgCreateBuilder.build({ | ||
| file: path.join(workspaceUtils.getRootWorkspacePath(), CONFIG_FILE), | ||
| alias: TEST_ALIAS, | ||
| expirationDays: TEST_ORG_EXPIRATION_DAYS | ||
| }); | ||
| expect(createCommand.toCommand()).to.equal( | ||
| `sfdx force:org:create -f ${CONFIG_FILE} --setalias ${TEST_ALIAS} --durationdays ${TEST_ORG_EXPIRATION_DAYS} --setdefaultusername --json --loglevel fatal` | ||
| `sfdx org:create:scratch --definition-file ${CONFIG_FILE} --alias ${TEST_ALIAS} --duration-days ${TEST_ORG_EXPIRATION_DAYS} --set-default --json` |
There was a problem hiding this comment.
This command uses JSON, which is why I'm asking about .withJson(false) in the other command.
daphne-sfdc
approved these changes
Jan 3, 2024
CristiCanizales
changed the title
peternhale
pushed a commit
that referenced
this pull request
Jan 5, 2024
* fix: org create commands to sf style * chore: loglevel flag to SF_LOG_LEVEL env var * chore: loglevel * chore: -f to --definition-file * chore: conflict after conflict resolution * chore: conflict after conflict resolution * chore: weird file
daphne-sfdc
added a commit
that referenced
this pull request
Jan 16, 2024
* fix: suppress warning for apex w/no coverage @W-10288513@ * chore: wip * chore: wip * chore: extract colorize for testability * chore: more optimizations * fix: org create command to sf style (#5295) * fix: org create commands to sf style * chore: loglevel flag to SF_LOG_LEVEL env var * chore: loglevel * chore: -f to --definition-file * chore: conflict after conflict resolution * chore: conflict after conflict resolution * chore: weird file * fix: correct log file name formatting error (#5316) @ W-13682486@ fix logfile name formatting error ensure the directory to the logfiles is present * chore: update to version 59.12.1 * chore: generated CHANGELOG for release/v59.12.1 * chore: update changelog * chore: update changelog * chore: update changelog * chore: update changelog * chore: updated SHA256 v59.12.1 [skip ci] * chore: wrong commands in package.json (#5317) * chore: update to version 59.12.2 * chore: generated CHANGELOG for release/v59.12.2 * chore: update changelog * chore: updated SHA256 v59.12.2 [skip ci] * fix: default SF_LOG_LEVEL to fatal (#5318) * chore: fix merge of develop * chore: add setting to control ui warnings Added a setting that allows user to disable coverage warning ui * chore: handle coverage exception in central spot Pass all coverage exception through single handler * chore: tweak exception handler for colorizer * Update packages/salesforcedx-vscode-apex/package.nls.json Co-authored-by: Daphne Yang <[email protected]> * chore: remove extra space --------- Co-authored-by: Cristina Cañizales <[email protected]> Co-authored-by: Release Bot <[email protected]> Co-authored-by: Daphne Yang <[email protected]> Co-authored-by: Daphne Yang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
What issues does this PR fix or reference?
@W-14700670@
Functionality Before
Functionality After