Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added shimmer effect on Skill listing Page #489

Merged
merged 3 commits into from
Jan 30, 2019
Merged

Added shimmer effect on Skill listing Page #489

merged 3 commits into from
Jan 30, 2019

Conversation

raghavbabbar
Copy link
Contributor

@raghavbabbar raghavbabbar commented Jan 18, 2019 •
edited
Loading

Added Shimmering Effect on SkillListing #485

screen shot 2019-01-19 at 1 36 56 am

@raghavbabbar
Copy link
Contributor Author

@jogendra please review

jogendra
jogendra suggested changes Jan 20, 2019
View reviewed changes
Copy link
Member

@jogendra jogendra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work with the PR. Some changes are required:

  • Add shimmer effect to the cell when new Language is selected from language selector.

@jogendra jogendra added Feature New feature Under Review The PR is under review by mentors. labels Jan 20, 2019
@raghavbabbar raghavbabbar force-pushed the RB_AddedShimmerEffectOnListing branch from 6b36ead to ed08a67 Compare January 20, 2019 11:36
@raghavbabbar raghavbabbar force-pushed the RB_AddedShimmerEffectOnListing branch from ed08a67 to 68bacae Compare January 20, 2019 11:39
@raghavbabbar
Copy link
Contributor Author

@jogendra changes have been done . you can review

@jogendra
Copy link
Member

@raghavbabbar please resolve the conflicts.

@raghavbabbar
Copy link
Contributor Author

@raghavbabbar please resolve the conflicts.

done please check

@jogendra jogendra removed the request for review from chashmeetsingh January 30, 2019 13:01
@jogendra jogendra merged commit 8126b7a into fossasia:master Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samagragupta samagragupta samagragupta approved these changes

@SIMRAN1 SIMRAN1 SIMRAN1 approved these changes

@jogendra jogendra jogendra approved these changes

Assignees
No one assigned
Labels
Feature New feature Under Review The PR is under review by mentors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@raghavbabbar @jogendra @SIMRAN1 @samagragupta