Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add confimation dialog and use it to handle discard ticket #2039

Closed
wants to merge 2 commits into from

Conversation

joshuarestivo
Copy link

Previously, the Discard button in the New Ticket view only cleared the contents of the editor. This was non-intuitive and not terribly useful. This PR creates a confirmation dialog component that is called by the Discard button. Selecting 'Yes' on the dialog routes the user back to the appropriate Ticket list view (Agent or Customer).
image

@RitvikSardana
Copy link
Member

Good PR @joshuarestivo .

Please remove package-lock.json file changes

also can you add the same for:

When a ticket is closed from customer portal, a confirmation popup should show.

@joshuarestivo
Copy link
Author

Happy to get rid of package-lock.json. Regarding closing a ticket from the customer portal, currently when you do that, a 'Rate this ticket' dialog appears. Do you want the confirmation instead of the ticket rating?

I've never been a fan of forced rating myself. I guess we could put a switch in Settings to select the desired close action (Rate Ticket or Confirm and Close).

Let me know your thoughts.

@RitvikSardana
Copy link
Member

RitvikSardana commented Nov 25, 2024

Hey joshua, I added the confirmation dialog along with this feature #2058

Thanks for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants