Raw Cmd in Print Designer #275
Conversation
IamSaiyyamChhetri
force-pushed
the
raw_print_pd
branch
from
80ce440 to
7967992
Compare
|
Sceenshots / demo video? |
|
Demo Video Link : https://drive.google.com/file/d/1_bupOIqog0XOCUmjYXEt5EIYZQ387zEB/view?usp=drive_link Images:
|
2. Overwrite printit() 3. Create template to render html
1. remove page-height args from options 2. call google-fonts macros
IamSaiyyamChhetri
force-pushed
the
raw_print_pd
branch
from
5dacb56 to
fdf43c1
Compare
2. Overwrite printit() 3. Create template to render html
1. remove page-height args from options 2. call google-fonts macros
signature field is saved as base64 encoded string in the database. i just added img tag and set the src attribute to the base64 encoded string.
* refactor(minor): call whitelisted method to get meta using with_doctype stores meta in localstorage which causes it to be full and is not required to replaced it with get_meta method in print designer * fix: send dynamicField instead of field. some keys are not in the field object such as parentField, so we need to send the dynamicField object instead.
from rectangle removed relative-column as there isn't any flex related css for column adding that class caused border to be removed when it was applied from rectangle class. also, added filter to remove classes getting added multiple times.
Variable and Conditional Changes
1. Add conditions 2. Add prompt before changing header/footer height as 0 if element present 3. Check if selected element is child 4. Add save raw_print related progress
feat : properties and ElementStore changes
feat : img render/ set rawLang to Mainstore
feat : Add validation on save to check that language is selected
Sub raw print pd
|
Demo Video: Covers:
https://drive.google.com/file/d/1CHmxALFgZ_LyQdvCawMdMAJ8voQHoJ7p/view?usp=sharing |
|
@IamSaiyyamChhetri a few problems: when selecting continuous roll option as the paper type, i can still fiddle around with page height - that should be set to auto and should not be allowed to change/change automatically? Screencast.2024-07-17.14.36.50.mp4have yet to test if printing with this works as expected or not but I tried out some stuff yesterday and things didnt work properly - every element when printed was coming up on the same (horizontal) line/row unlike the design (shown in the video) - maybe I'm missing something? |
|
also, the format looks different in the editor mode v/s the print mode
notice how there is extra padding in the print mode.
This is how the print of that format looks like:
|
|
@phot0n page size is correct. styles are not applied to the table |
|
Hi @maharshivpatel / @phot0n , |
|
@IamSaiyyamChhetri I've mentioned the major problems in the above comments ...did you get a chance to work on them? |
|
the state management of the raw printing command also seems wonky Screencast.2024-07-24.10.02.14.mp4note how the command placement (before -> after) changed for all the elements in the designer |
|
Hi @phot0n, |
|
fixed some stuff and the print(s) have started to come a bit cleanly and the full cut seems to be working (not really sure about the partial cut as both seemed to cut the same amount of length) ..there are still a few issues remaining
|
|
As it was discussed on call with different contributors in order to merge this PR we need at-least 90% of compatibility. if user is designing something in Print designer they should be able to print the same with thermal printer. In the last call when we reviewed this images, css styles, fonts were not working at all. please fix this issues and if they are not required then disable them when raw_printing_mode is enabled. users expect to have 1-1 relation between design and thermal printing ( at-least majority should be same we can work on edge cases). PR in this state cannot be merged please make necessary changes. Thank you so much for contributing. |
|
@maharshivpatel does this interfere with existing layouts? If not, let's merge? @phot0n can you update the branch and move it from Draft? |
Disable Colors or change control to select field with black and white as options
Dynamic Text ( Font Family, Style, Height [ Auto, Fixed ] )
Table ( Borders, Padding )
Embed Image and check size
Disable Header / Footers
Check Barcode Printing / Also consider internal barcode options ( not required )
Layout is preserved with overlapping elements
Write Patch to create and set default values for required fields.
Only Show Raw Printing Section If Raw Printing is enabled
Add validation on save to check that language is selected
Check if Element is overlapping at the top and / or bottom and disable command options.
Add Empty / Disable Option in Raw Command Before / After so user can remove the command.