-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
smbfs(4): evaluate filesystems/smbnetfs #1562
base: main
Are you sure you want to change the base?
Conversation
RIP sysutils/fusefs-smbnetfs, one of 142 moves that arose from freebsd/freebsd-ports#302 and base 6e2da9672f79 on 2024-11-06. This one involved a change of name in addition to the change of category. Instead, advise users to evaluate filesystems/smbnetfs. MFC after: 1 day
Plain text, with line breaks:
|
Sorry, I made a mistake in the commit log message at
– should have been:
|
From freebsd/freebsd-ports#302 (comment) (2024-11-13):
The suggested one-week MFC here (Friday 27th December, looking to Thursday 2nd January) is, partly, an allowance for the change in ports to reach quarterly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry to back track, but I only just now realized why the previous location was incorrect.
This could use a better commit message to make that more obvious. Suggest something like:
smbfs.4: Update smbnetfs location
A new "filesystems" ports category has been created,
and all filesystem ports have been moved there.
Update the smbnetfs manual to point to the new location.
PR: the number of the bug you opened for this issue
Fixes: ports#short-commit-hash(Commit title)
MFC after: 3 days
Key points: the .4 instead of (4) shows you're talking about the manual, not the driver itself.
The description explains why this change is happening without needing to follow links, and what is happening without having to look at everything. This is extremely important.
Please don't put hyperlinks in the middle of the text because it isn't legible. People need to read the description, and that gives them the context to decide to go look up the links.
You opened a bug to track this issue, using it makes that useful.
Additionally, but not my call, it's vastly preferred that everything in src/ effected by this should be one commit.
Thanks!
This can be closed, I did all the fallout in the src tree in one commit here 1. I'm about 1/3rd of the way through doing the same in the doc tree. Footnotes |
RIP sysutils/fusefs-smbnetfs, one of 142 moves that arose from
freebsd/freebsd-ports#302 and
ports 6e2da9672f79 on 2024-11-06. This one involved a change of name
in addition to the change of category.
Instead, advise users to evaluate filesystems/smbnetfs.
MFC after: 1 week