no, wait - set NODE_ENV in the dockerfile instead

freemocap · May 16, 2024 · 4b0a192 · 4b0a192
1 parent dc639f3
commit 4b0a192
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/Dockerfile b/Dockerfile
@@ -37,4 +37,6 @@ COPY . .
 
 RUN npm run build
 
+ENV NODE_ENV=production
+
 ENTRYPOINT ["/usr/bin/dumb-init", "--", "npm", "run", "start:prod"]
diff --git a/gcloud/GCE.txt b/gcloud/GCE.txt
@@ -16,4 +16,3 @@ gcloud compute instances create-with-container skelly-bot-testing \
     --shielded-vtpm \
     --shielded-integrity-monitoring \
     --labels=goog-ec-src=vm_add-gcloud,container-vm=cos-stable-109-17800-66-54
-    --container-env NODE_ENV=production
Original file line number	Diff line number	Diff line change
Expand Up		@@ -37,4 +37,6 @@ COPY . .

		RUN npm run build

		ENV NODE_ENV=production

		ENTRYPOINT ["/usr/bin/dumb-init", "--", "npm", "run", "start:prod"]