Patch Mediapipe skeleton ordering #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaroncherian
approved these changes
Mar 13, 2024
There was a problem hiding this comment.
Ran a session through and it worked for me!
For the future, we should maybe look at whether we can import this list from skellytracker into FreeMoCap proper when we split and export, instead of recreating it? That way for this, and for future options, we don't accidentally run into this problem again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in the mediapipe model info that was causing the mediapipe output array to be ordered incorrectly (pose, face, left hand, right hand). This fixes the ordering to (pose, right hand, left hand, face). This now matches Freemocap's ordering, and fixes the bugs we were having with hands in Blender.