Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tracker dependencies to extras #27

Merged
merged 9 commits into from
Apr 25, 2024

Conversation

philipqueen
Copy link
Collaborator

@philipqueen philipqueen commented Mar 18, 2024

Fixes #23.

Removes all of the pose estimators/tracking algorithms from the core dependencies and moves them into extras. Download options would be:

pip install skellytracker - just the core package
pip install 'skellytracker[mediapipe]' - core package and mediapipe
pip install 'skellytracker[yolo]' - core package and ultralytics (YOLO)
pip install 'skellytracker[all]' - core package, mediapipe, and ultralytics/YOLO

this is very easy to maintain and add to. Freemocap can just import [all] for now, but it gives us an option to change the download if ever include less commonly used trackers.

I've had to add conditional imports to files that download multiple trackers, but everything successfully runs. You can execute the RUN_ME and process_folder_of_videos in the limited install versions as long as you're using a tracker that's installed (e.g. missing YOLO doesn't throw an error when you try to run mediapipe).

Copy link
Member

@jonmatthis jonmatthis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put some newlines around the "need to install" print statements to make them easier to see among the terminal output

@philipqueen
Copy link
Collaborator Author

Put some newlines around the "need to install" print statements to make them easier to see among the terminal output

Done! Also Github added a cool new "batch suggestion" option where you can add all the suggestions to a batch and add them in one commit

@philipqueen philipqueen requested a review from jonmatthis April 25, 2024 16:32
@philipqueen philipqueen merged commit 48e366a into main Apr 25, 2024
@philipqueen philipqueen deleted the philip/move_trackers_to_extras branch April 25, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lighter weight packaging through extras
2 participants