Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mediapipe_model_info.py #31

Conversation

aaroncherian
Copy link
Contributor

Updating mediapipe model info in advance of incoming pipeline updates

@aaroncherian aaroncherian requested a review from philipqueen April 9, 2024 19:37
@philipqueen
Copy link
Collaborator

Ok, I went through and made the changes to the underlying ModelInfo base class, including more accurate type hints.

I also formatted the mediapipe model info code, and added back in some things that were used elsewhere. One was the tracked object names, which is needed in skellytracker, and the rest were information about the face and hands, which is necessary for the mediapipe tracker to run now.

As we discussed, we may want to split out the hands and face eventually. But for now keeping the underlying tracker working will be good for testing.

@philipqueen philipqueen merged commit df7ceb8 into philip/flesh_out_mediapipe_model_info Apr 13, 2024
@philipqueen philipqueen deleted the aaron/update_mediapipe_model_info branch April 13, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants