Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build with cmake (qt6) #213

Closed
wants to merge 2 commits into from
Closed

Fix build with cmake (qt6) #213

wants to merge 2 commits into from

Conversation

EndrII
Copy link

@EndrII EndrII commented Dec 27, 2021

Add support qt6 library for CMake build system.

Search order of qt libraries

  • If the QT_VERSION_MAJOR variable not defined then CMake try find Qt6.
  • If Qt6 is not exists the CMake try search qt5.

If you have two qt version on one machine you can force sets QT_VERSION_MAJOR for build

@EndrII EndrII marked this pull request as draft December 27, 2021 21:32
@EndrII
Copy link
Author

EndrII commented Dec 27, 2021

still not working with QZXING_MULTIMEDIA

@dabbinavo
Copy link

Hey @EndrII, just created a pull request (#214) for the same thing and now saw that you already opened one 2 days ago.

In principle they are very similar. I like your idea of letting the user manually define QT_VERSION_MAJOR instead of letting the find_package function determine it. Also that the multimedia package only is searched if needed at all.

I think whats missing in your implementation is the check for Qt 6.2+ that has to include QZXingFilterVideoSink.cpp/h instead of QZXingFilter.cpp/h. Qt6 versions before 6.2 do not support multimedia at all. Cmake normally should fail than on the find_package command.

So what should we do? Do you want to update your pull request to work with Qt6.2 or should I update mine with your improvements?

@EndrII
Copy link
Author

EndrII commented Dec 29, 2021

@dabbinavo i close this pull request. but i fuoun some issues in youe PR. please fix

@EndrII EndrII closed this Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants