Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean up formatting #18

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

chore: clean up formatting #18

wants to merge 6 commits into from

Conversation

mehtaculous
Copy link
Collaborator

No description provided.

@mehtaculous mehtaculous self-assigned this Dec 5, 2023
@mehtaculous mehtaculous added the in review Ready for review label Dec 5, 2023
@mehtaculous
Copy link
Collaborator Author

@stevennevins can you pls improve the natspec for the getInodeAt function, I don't quite understand what it should be doing..

also improve natspec for the structs, if needed

src/FileSystem.sol Outdated Show resolved Hide resolved
@stevennevins
Copy link
Collaborator

@stevennevins can you pls improve the natspec for the getInodeAt function, I don't quite understand what it should be doing..

also improve natspec for the structs, if needed

Inodes can be nested. getInodeAt traverses the directory and returns an Inode

@mehtaculous
Copy link
Collaborator Author

@stevennevins can you pls improve the natspec for the getInodeAt function, I don't quite understand what it should be doing..
also improve natspec for the structs, if needed

Inodes can be nested. getInodeAt traverses the directory and returns an Inode

so the inodeChecksum needs to be found in each path segment in the list ? seems we're iterating the list of paths but reverting after the first one if a checksum isn't found..

@stevennevins
Copy link
Collaborator

e

Yeah if it doesn't exist when traversing the list of path segments we revert

@mehtaculous
Copy link
Collaborator Author

e

Yeah if it doesn't exist when traversing the list of path segments we revert

but we're reverting after the first path..shouldn't it be at the very end ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in review Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants