Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdf-gallery #90

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

pdf-gallery #90

wants to merge 2 commits into from

Conversation

paproc
Copy link
Contributor

@paproc paproc commented Dec 29, 2024

No description provided.

@Headary
Copy link
Member

Headary commented Dec 30, 2024

Když už tam chceš tu magii o vytahování jména souboru z PDF, tak to trochu zkrášli, používat jednopísmenné proměnné je matoucí + chceš používat === místo ==.

@cevro
Copy link
Member

cevro commented Dec 30, 2024

$object_no = (int) $a[1];
casing.

nahradiť === , alebo niečim bez jugglingu

inteligetné pomenovanie premennej, obecne všade v tom súbore, ak sa nebavíme o x a y ako osiach, alebo naozaj výpočte tak jendopísmenné názvy sa nemajú používať.

použiť krátku syntax

public static function getPdfProp($file): array
typ argumentu?

https://github.com/fykosak/webs/blob/2c6f20e5f8461e12e44803f212c807d63feade12/app/Components/PdfGallery/PdfGalleryControl.php#L106C16-L106C21 teda je to string[], alebo int[]|string[]|float[] ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants