pictures preview #94
Open
pictures preview #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cevro
reviewed
Jan 12, 2025
| @@ -142,4 +145,29 @@ protected function createComponentPdfGallery(): PdfGalleryControl | |||
| { | |||
| return new PdfGalleryControl($this->getContext()); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Tymto sa odrezáva vo všetkých presenteroch akcia preview, čo je veľmi, zlé ak by ju niekto chcel výhladovo použiť.
Ak sa takto nejaká akcia vyčlení (čo je zlý koncpet), tak sa má zafixovať, že že ju nikto neprepíše pomocou final
Každopádne riešenie tohoto je spraviť samostaný presenter, ktorý bude rešiť len fotky.
cevro
reviewed
Jan 12, 2025
app/Modules/Core/BasePresenter.php
Outdated
|
|
||
| private readonly string $wwwDir; | ||
|
|
||
| public function injectWwwDir(Container $container): void |
There was a problem hiding this comment.
Načo? V presenteri je DI kontainer dostupný.
cevro
reviewed
Jan 12, 2025
| 'width' => $imageInfo[0], | ||
| 'height' => $imageInfo[1], | ||
| ]; | ||
| if (strpos($wwwPath, '/media/') === 0) { |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.