Feature/convict with config volume #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-ready-4-merge Feature/crkrenn/convict ready 4 merge
modified client-participation build to be the same as the client-admin build
…nn/polis into feature/convict-with-config-volume
patcon
reviewed
Jan 28, 2022
| }, | ||
| { | ||
| "path": "client-participation/dist/cached/*/js/vis_bundle.js", | ||
| "path": "client-participation/dist/*.js", |
patcon
reviewed
Jan 28, 2022
| @@ -1,6 +1,7 @@ | |||
| name: "Bundlewatch Github Action" | |||
|
|
|||
| on: | |||
| workflow_dispatch: | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All,
With some direction from me and the heavy lifting by @tamas-soos-toptal, we have made progress on compdemocracy#220
We now have a working branch of the current dev branch that uses node-convict for configuration instead of the mix of config files and environmental variables for javascript configuration. (To integrate with the math container, we would need to write some clojure to read an intermediate yaml file.)
This branch passes all of the same e2e tests as the dev branch. We have not tested with google translate credentials yet.
I know there are a lot of files modified, but they fall into 3 categories:
New code in the config directory.
Definition of variables and defaults in schema.yaml
Necessary modifications of the docker-compose mechanics.
Modification of java script files that use config variables.
I'm guessing that you may have questions or suggestions. Is it worth putting this on an agenda for a Saturday jit.si call?
-Chris