Fix lint errors

gafirst · Jan 9, 2025 · 0fbc9bd · 0fbc9bd
1 parent fc29911
commit 0fbc9bd
Show file tree

Hide file tree

Showing 14 changed files with 49 additions and 23 deletions.
diff --git a/client/package.json b/client/package.json
@@ -7,7 +7,7 @@
     "preview": "vite preview",
     "lint": "eslint . --ignore-pattern .gitignore",
     "lint:fix": "eslint . --fix --ignore-pattern .gitignore",
-    "lint:ci": "eslint . --max-warnings=0 --output-file eslint_report.json --format json --ignore-path .gitignore"
+    "lint:ci": "eslint . --max-warnings=0 --output-file eslint_report.json --format json --ignore-pattern .gitignore"
   },
   "dependencies": {
     "@mdi/font": "^7.4.47",

diff --git a/client/src/components/alerts/NoPlaylistMappings.vue b/client/src/components/alerts/NoPlaylistMappings.vue
@@ -9,7 +9,9 @@
   >
     <template #text>
       <strong>No playlist mappings defined.</strong> Define playlist mappings in
-      <RouterLink to="/settings">Settings</RouterLink> if you want your videos added to YouTube playlists after being
+      <RouterLink to="/settings">
+        Settings
+      </RouterLink> if you want your videos added to YouTube playlists after being
       uploaded and to use the Match Upload Status report.
     </template>
   </VAlert>

diff --git a/client/src/components/autoRename/AutoRenameAssociations.vue b/client/src/components/autoRename/AutoRenameAssociations.vue
@@ -15,12 +15,14 @@
     multi-sort
     :sort-by="[{ key: 'videoLabel', order: 'asc' }, { key: 'videoTimestamp', order: 'asc' }]"
   >
+    <!-- eslint-disable-next-line vue/valid-v-slot -->
     <template #item.status="{ item }">
       <VChip :color="statusToColor(item.status)">
         {{ statusIncludingRenames(item) }}
       </VChip>
     </template>
 
+    <!-- eslint-disable-next-line vue/valid-v-slot -->
     <template #item.actions="{ item }">
       <VAlert
         v-if="item.renameJobId &&
@@ -33,6 +35,7 @@
       >
         File rename failed. Click Review for details.
       </VAlert>
+
       <div class="d-flex mt-2 mb-2">
         <VBtn
           class="mr-2"
@@ -67,10 +70,12 @@
       </div>
     </template>
 
+    <!-- eslint-disable-next-line vue/valid-v-slot -->
     <template #item.videoTimestamp="{ item }">
       {{ dayjs(item.videoTimestamp).format("llll z") }}
     </template>
 
+    <!-- eslint-disable-next-line vue/valid-v-slot -->
     <template #item.matchKey="{ item }">
       {{ item.matchName ?? "None" }}<br>
       <span style="color: gray">{{ item.matchKey ?? "" }}</span>
@@ -113,11 +118,10 @@ dayjs.extend(localizedFormat);
 dayjs.extend(timezone);
 dayjs.extend(utc);
 
-const props = defineProps<{
+defineProps<{
   includedAssociationStatuses: AutoRenameAssociationStatus[];
 }>();
 
-
 const autoRenameStore = useAutoRenameStore();
 autoRenameStore.getAssociations();
 

diff --git a/client/src/components/autoRename/AutoRenameReviewDialogContents.vue b/client/src/components/autoRename/AutoRenameReviewDialogContents.vue
@@ -152,6 +152,7 @@
             hide-default-header
             hide-default-footer
           >
+            <!-- eslint-disable-next-line vue/valid-v-slot -->
             <template #item.value="{ item }">
               <span v-if="item.key.toLowerCase() === 'match'">
                 <MatchAutocompleteDropdown

diff --git a/client/src/components/form/AutosavingTextInput.vue b/client/src/components/form/AutosavingTextInput.vue
@@ -93,16 +93,17 @@
 import {computed, ref} from "vue";
 import {SettingType} from "@/types/ISettings";
 
- 
+
 enum State {
   LOADING,
   READY,
   SUCCESS,
   ERROR,
 }
- 
+
 
 interface IProps {
+  // eslint-disable-next-line @typescript-eslint/no-unsafe-function-type
   onSubmit: Function;
   name: string;
   label: string;
@@ -119,12 +120,12 @@ const emit = defineEmits(["savedValueUpdated"]);
 const state = ref<State>(State.READY);
 
 // TODO: These no-setup-props-destructure rules are valid but not breaking the component
- 
+
 const inputValue = ref(props.initialValue);
- 
+
 const lastSubmittedValue = ref(props.initialValue);
 const error = ref("");
- 
+
 const showPlainText = ref(props.inputType === "text");
 
 async function submit() {

diff --git a/client/src/components/matches/MatchAutocompleteDropdown.vue b/client/src/components/matches/MatchAutocompleteDropdown.vue
@@ -32,6 +32,7 @@ const matchListStore = useMatchListStore();
 
 matchListStore.getMatchList();
 
+// eslint-disable-next-line vue/require-prop-types
 const model = defineModel();
 
 function matchSelected(value: string) {

diff --git a/client/src/components/reports/MatchUploadStatus.vue b/client/src/components/reports/MatchUploadStatus.vue
@@ -37,7 +37,10 @@
       </VAlert>
     </VCol>
   </VRow>
-  <VRow class="ml-1 mb-2" v-if="playlistsStore.playlistMappingsExist">
+  <VRow
+    v-if="playlistsStore.playlistMappingsExist"
+    class="ml-1 mb-2"
+  >
     <VCol
       md="3"
     >
@@ -72,14 +75,18 @@
     </VCol>
   </VRow>
 
-  <VAlert v-if="!playlistsStore.playlistMappingsExist"
-            color="warning"
-            variant="tonal"
-            icon="mdi-alert-circle-outline"
-          >
-    To use this report, define at least one playlist mapping in <RouterLink to="/settings">Settings</RouterLink>.
+  <VAlert
+    v-if="!playlistsStore.playlistMappingsExist"
+    color="warning"
+    variant="tonal"
+    icon="mdi-alert-circle-outline"
+  >
+    To use this report, define at least one playlist mapping in <RouterLink to="/settings">
+      Settings
+    </RouterLink>.
   </VAlert>
-  <VDataTable v-else
+  <VDataTable
+    v-else
     :items="items"
     items-per-page="-1"
     density="compact"

diff --git a/client/src/stores/match.ts b/client/src/stores/match.ts
@@ -198,6 +198,8 @@ export const useMatchStore = defineStore("match", () => {
       matchVideos.value.some(video => videoIsUploaded(video));
   });
 
+  // TODO: Add types for this function
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   async function uploadVideo(video: MatchVideoInfo): Promise<any> {
     video.isRequestingJob = true;
     video.jobCreationError = null;
@@ -235,6 +237,7 @@ export const useMatchStore = defineStore("match", () => {
       return;
     }
 
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
     const result: any = await response.json();
 
     if (response.ok) {
@@ -247,6 +250,7 @@ export const useMatchStore = defineStore("match", () => {
       // Catches if the server returns parameter validation errors
       if (result.errors) {
         console.log("errors", result.errors);
+        // eslint-disable-next-line @typescript-eslint/no-explicit-any
         video.jobCreationError = result.errors.map((error: any) => error.msg).join(", ");
       } else {
         video.jobCreationError = result.error;
@@ -345,6 +349,7 @@ export const useMatchStore = defineStore("match", () => {
     return !!job.linkedOnTheBlueAlliance && !!job.addedToYouTubePlaylist;
   }
 
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   watch(isReplay, async (value, oldValue, onCleanup) => {
     await getMatchVideos();
     await getSuggestedDescription();

diff --git a/client/src/stores/playlists.ts b/client/src/stores/playlists.ts
@@ -7,7 +7,7 @@ export const usePlaylistsStore = defineStore("playlists", () => {
   const loading = ref(false);
   const isFirstLoad = ref(true);
   const error = ref<string>("");
-  const playlistMappingsExist = computed(() => !isFirstLoad.value && (playlists.value?.length ?? 0) > 0)
+  const playlistMappingsExist = computed(() => !isFirstLoad.value && (playlists.value?.length ?? 0) > 0);
 
   const playlistMappings = computed(() => {
     if (!playlists.value) {
@@ -64,6 +64,8 @@ export const usePlaylistsStore = defineStore("playlists", () => {
     isFirstLoad.value = false;
   }
 
+  // TODO: Remove any types from this file
+
   /**
    * Save a playlist mapping
    *
@@ -91,6 +93,7 @@ export const usePlaylistsStore = defineStore("playlists", () => {
 
     if (resultJson.errors) {
       apiError = true;
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any
       error.value = resultJson.errors.map((error: any) => error.msg).join(", ");
     }
 
@@ -118,6 +121,7 @@ export const usePlaylistsStore = defineStore("playlists", () => {
 
     if (resultJson.errors) {
       apiError = true;
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any
       error.value = resultJson.errors.map((error: any) => error.msg).join(", ");
     }
 

diff --git a/client/src/stores/uploadedVideos.ts b/client/src/stores/uploadedVideos.ts
@@ -1,6 +1,5 @@
 import { acceptHMRUpdate, defineStore } from "pinia";
 import { computed, ref } from "vue";
-import { isUploadedVideo, UploadedVideo } from "@/types/UploadedVideo";
 import { isEventUploadStatusByMatch, UploadStatusSummary, UploadTotalsSummary } from "@/types/EventUploadStatusByMatch";
 
 export const useUploadedVideosStore = defineStore("uploadedVideos", () => {

diff --git a/client/src/views/Settings.vue b/client/src/views/Settings.vue
@@ -540,6 +540,7 @@ async function submitEventCode(settingName: string, value: string | boolean, set
   return submitResult;
 }
 
+// eslint-disable-next-line @typescript-eslint/no-unused-vars
 async function saveDescriptionTemplate(settingName: string, value: string, settingType: SettingType) {
   return await settingsStore.saveDescriptionTemplate(value);
 }

diff --git a/server/package.json b/server/package.json
@@ -5,7 +5,7 @@
     "build": "npx ts-node build.ts",
     "lint": "npx eslint src/ spec/",
     "lint:fix": "npx eslint --fix  src/ spec/",
-    "lint:ci": "npx eslint --max-warnings=0 --output-file eslint_report.json --format json --ext .ts src/ spec/",
+    "lint:ci": "npx eslint --max-warnings=0 --output-file eslint_report.json --format json src/ spec/",
     "start": "npx prisma migrate deploy && node -r module-alias/register ./dist --env=production",
     "start:worker": "node -r module-alias/register ./dist/worker.js --env=production",
     "dev": "nodemon",

diff --git a/server/src/services/YouTubeService.ts b/server/src/services/YouTubeService.ts
@@ -25,7 +25,8 @@ export async function getGoogleOAuth2Client(requestProtocol: string): Promise<OA
     const settings = await getSettings();
     const secrets = await getSecrets();
 
-    // @ts-ignore
+    // @ts-expect-error This OAuth2 client is correct, but the types don't match for unclear reasons that aren't worth
+    // investigating right now
     return new auth.OAuth2(
         settings.googleClientId,
         secrets.googleClientSecret,

diff --git a/server/src/tasks/uploadVideo.ts b/server/src/tasks/uploadVideo.ts
@@ -127,7 +127,7 @@ export async function uploadVideo(payload: unknown, { logger, job }: JobHelpers)
             });
         } catch (e: unknown) {
             logger.error(`Unable to save UploadedVideo ${payload.videoPath} with YouTube ID ` +
-              `${uploadResult.videoId}: ${JSON.stringify(e)}`)
+              `${uploadResult.videoId}: ${JSON.stringify(e)}`);
         }
 
         try {
@@ -171,7 +171,7 @@ export async function uploadVideo(payload: unknown, { logger, job }: JobHelpers)
             });
         } catch (e: unknown) {
             logger.error(`Unable to update UploadedVideo ${payload.videoPath} with YouTube ID ` +
-              `${uploadResult.videoId}: ${JSON.stringify(e)}`)
+              `${uploadResult.videoId}: ${JSON.stringify(e)}`);
         }
     } else if (isYouTubeVideoUploadError(uploadResult)) {
         logger.error(`Failed to upload video ${payload.title}: ${uploadResult.error}`);