Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): Restructure videos directory by label #92

Merged
merged 12 commits into from
Feb 12, 2024
Merged

Conversation

evan10s
Copy link
Member

@evan10s evan10s commented Feb 10, 2024

  • Modifies the videos directory so video labels are represented as folders
  • Uploaded videos are moved into an uploaded directory within their label directory
    • This allows videos that are already uploaded to be indicated in the UI
    • In sandbox mode, videos are not moved the the uploaded directory, but the from/to paths are printed in the logs for confirmation purposes

Other goodies:

  • Queue all button changes to Queue all remaining to clarify that it will only trigger uploads on videos that have not been uploaded yet
  • If a video file doesn't exist at upload time (which may be seconds or minutes or hours past when it was queued for upload), the job fails with the error but will no longer crash the worker

image
image

Fixes #78
Closes #49
Closes #69

TODO:

  • Update readme
  • Update in-app instructions on where to put video files
  • Include breaking change note in commit description before merging: BREAKING CHANGE: The structure of the videos directory has changed to include video labels as subdirectories, and you will need to adjust your workflow accordingly. Details of the new structure are available in the README at https://github.com/gafirst/match-uploader/blob/main/README.md#video-directory-structure.

@evan10s evan10s marked this pull request as draft February 10, 2024 04:13
@evan10s evan10s marked this pull request as ready for review February 11, 2024 23:00
@evan10s evan10s enabled auto-merge (squash) February 12, 2024 05:00
@evan10s evan10s merged commit 3a583ad into main Feb 12, 2024
10 checks passed
@evan10s evan10s deleted the evan/video-labels branch February 12, 2024 05:01
Copy link

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
1 participant