Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Seurat version of the PBMC clustering tutorial #5491

Merged
merged 82 commits into from
Jan 23, 2025

Conversation

MarisaJL
Copy link
Collaborator

This is the Seurat version of the Clustering3k PMBCs with Scanpy tutorial for single cell.

@MarisaJL MarisaJL marked this pull request as ready for review January 13, 2025 08:59
@MarisaJL MarisaJL requested a review from pavanvidem January 20, 2025 10:42
MarisaJL and others added 2 commits January 20, 2025 10:42
we should fix this on the framework side, but this is the quickest way until then
Copy link
Member

@shiltemann shiltemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @MarisaJL, looks great!

@shiltemann
Copy link
Member

Thanks for the updates @MarisaJL! The current linting error is a new one for me (and not very informative), will investigate what is causing it

Copy link
Member

@shiltemann shiltemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @MarisaJL ok, had a look at the linting error, and pushed some changes, explanations below (and one TODO for you). Thanks!

@MarisaJL
Copy link
Collaborator Author

Hey @MarisaJL ok, had a look at the linting error, and pushed some changes, explanations below (and one TODO for you). Thanks!

Thank you! I'll sort these out and hopefully nothing else will appear!!

Copy link
Member

@shiltemann shiltemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarisaJL thanks a lot! This is a massive tutorial and looks extremely comprehensive, amazing job!

I did another pass and technically it all looks great to me now

Will give one of the @galaxyproject/training-single-cell team a chance to review the scientific content and merge, but from my side this looks good!

@shiltemann
Copy link
Member

oh, I see now that @pavanvidem already reviewed before, so maybe he can just have a final look and merge? :)

Copy link
Member

@pavanvidem pavanvidem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested locally and it looks super nice with CYOA. Definitely one of most detailed tutorials. Thanks a lot @MarisaJL

@pavanvidem pavanvidem merged commit b42014f into galaxyproject:main Jan 23, 2025
3 checks passed
@MarisaJL
Copy link
Collaborator Author

Thank you both!

I'm working on another tutorial with lots of cyoa in it, so @shiltemann 's feedback will help me to avoid the same problems there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants