-
Notifications
You must be signed in to change notification settings - Fork 926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Seurat version of the PBMC clustering tutorial #5491
Conversation
Removing old images to replace with newer ones
we should fix this on the framework side, but this is the quickest way until then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @MarisaJL, looks great!
Co-authored-by: Saskia Hiltemann <[email protected]>
Thanks for the updates @MarisaJL! The current linting error is a new one for me (and not very informative), will investigate what is causing it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @MarisaJL ok, had a look at the linting error, and pushed some changes, explanations below (and one TODO for you). Thanks!
Thank you! I'll sort these out and hopefully nothing else will appear!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MarisaJL thanks a lot! This is a massive tutorial and looks extremely comprehensive, amazing job!
I did another pass and technically it all looks great to me now
Will give one of the @galaxyproject/training-single-cell team a chance to review the scientific content and merge, but from my side this looks good!
oh, I see now that @pavanvidem already reviewed before, so maybe he can just have a final look and merge? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested locally and it looks super nice with CYOA. Definitely one of most detailed tutorials. Thanks a lot @MarisaJL
Thank you both! I'm working on another tutorial with lots of cyoa in it, so @shiltemann 's feedback will help me to avoid the same problems there |
This is the Seurat version of the Clustering3k PMBCs with Scanpy tutorial for single cell.