Fix: Fixed issue where Git submenu was shown for non-GitHub repos (fi…

…les-community#15197)
gave92 · Apr 16, 2024 · 8c96b8f · 8c96b8f
1 parent 93e5754
commit 8c96b8f
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/src/Files.App/Data/Models/CurrentInstanceViewModel.cs b/src/Files.App/Data/Models/CurrentInstanceViewModel.cs
@@ -139,16 +139,23 @@ public bool CanTagFilesInPage
 			get => !isPageTypeRecycleBin && !isPageTypeFtp && !isPageTypeZipFolder;
 		}
 
-		public bool IsGitRepository => !string.IsNullOrWhiteSpace(gitRepositoryPath);
+		private bool isGitRepository;
+		public bool IsGitRepository
+		{
+			get => isGitRepository;
+			set
+			{
+				SetProperty(ref isGitRepository, value);
+			}
+		}
 
 		private string? gitRepositoryPath;
 		public string? GitRepositoryPath
 		{
 			get => gitRepositoryPath;
 			set
 			{
-				if (SetProperty(ref gitRepositoryPath, value))
-					OnPropertyChanged(nameof(IsGitRepository));
+				SetProperty(ref gitRepositoryPath, value);
 			}
 		}
 

diff --git a/src/Files.App/Views/HomePage.xaml.cs b/src/Files.App/Views/HomePage.xaml.cs
@@ -58,6 +58,7 @@ protected override async void OnNavigatedTo(NavigationEventArgs e)
 			AppInstance.InstanceViewModel.IsPageTypeZipFolder = false;
 			AppInstance.InstanceViewModel.IsPageTypeLibrary = false;
 			AppInstance.InstanceViewModel.GitRepositoryPath = null;
+			AppInstance.InstanceViewModel.IsGitRepository = false;
 			AppInstance.ToolbarViewModel.CanRefresh = true;
 			AppInstance.ToolbarViewModel.CanGoBack = AppInstance.CanNavigateBackward;
 			AppInstance.ToolbarViewModel.CanGoForward = AppInstance.CanNavigateForward;

diff --git a/src/Files.App/Views/Shells/BaseShellPage.cs b/src/Files.App/Views/Shells/BaseShellPage.cs
@@ -251,6 +251,7 @@ protected async void FilesystemViewModel_DirectoryInfoUpdated(object sender, Eve
 			if (InstanceViewModel.GitRepositoryPath != FilesystemViewModel.GitDirectory)
 			{
 				InstanceViewModel.GitRepositoryPath = FilesystemViewModel.GitDirectory;
+				InstanceViewModel.IsGitRepository = FilesystemViewModel.IsValidGitDirectory;
 
 				InstanceViewModel.GitBranchName = headBranch is not null
 					? headBranch.Name