Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORCID and ROR updates #31

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

ORCID and ROR updates #31

wants to merge 5 commits into from

Conversation

qqmyers
Copy link
Member

@qqmyers qqmyers commented Jan 9, 2025

This PR:

  • adds support for using the ORCID sandbox
  • supports display when ORCID accounts do not have/share a last name
  • fixes an issue (orcid and ror) with updated selections sometimes not being sent to Dataverse/resulting in author required/related errors
  • changes the documentation to point to the gdcc orcid/ror scripts (vs QDR's)
  • removes some duplicate code in the ROR script

As documented in the code, for hidden input fields, I've seen that using the jQuery val() method gets the new values sent to Dataverse consistently while using attr('value', ) sets the value attribute for the input so it can be seen in the browser console. Neither does both. We nominally only need the value sent to Dataverse, but I've used both methods to hopefully simplify debugging a bit. I don't fully understand why this is - I assume there's some different in event propagation for hidden inupts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant